fix: message list to revert previous change#43
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR reworks the macOS chat transcript scrolling behavior in RxCodeChatKit to keep the message list anchored to the bottom (including across session open, disk-load completion, and streaming→settled handoffs), effectively reverting the prior “pin latest user message / dynamic tail spacer” approach.
Changes:
- Removes the dynamic tail spacer + “pin latest user message to top” tracking logic.
- Introduces a fixed 1pt bottom sentinel row as the universal scroll-to-bottom target.
- Adds scroll-phase gating plus a multi-frame “settle at bottom” sweep to reduce offset snaps during
Listreload/layout.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+271
to
279
| /// Debounced scroll-to-bottom for content growth. Re-armed on every geometry | ||
| /// change, so a burst of streaming deltas collapses into a single scroll. | ||
| private func scrollToBottomDebounced(_ proxy: ScrollViewProxy) { | ||
| scrollTask?.cancel() | ||
| scrollTask = Task { @MainActor in | ||
| try? await Task.sleep(for: .milliseconds(50)) | ||
| guard !Task.isCancelled else { return } | ||
| guard !Task.isCancelled, !isUserDrivenScroll else { return } | ||
| scrollToBottom(proxy) | ||
| } |
| switch scrollPhase { | ||
| case .interacting, .tracking, .decelerating: return true | ||
| case .idle, .animating: return false | ||
| @unknown default: return false |
Contributor
Author
|
🎉 This PR is included in version 1.9.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.