Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Adds an “Open in GitHub” action to the external editor toolbar menu, backed by shared Git remote URL helpers in RxCodeCore. The PR also migrates app icon configuration to a new Icon Composer resource.
Changes:
- Adds GitHub URL generation/detection helpers and uses them from the toolbar menu.
- Refactors project GitHub repo detection to use the shared core helper.
- Replaces the legacy app icon asset catalog entry with
icon.icon.
Reviewed changes
Copilot reviewed 7 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
RxCode/Views/Toolbar/ExternalEditorMenu.swift |
Adds the “Open in GitHub” menu item and service helper. |
RxCode/App/AppState.swift |
Uses the shared GitHub owner/repo detector when adding folder projects. |
Packages/Sources/RxCodeCore/Utilities/GitURLHelpers.swift |
Adds GitHub web URL construction and Git remote detection helpers. |
Packages/Tests/RxCodeCoreTests/GitURLHelpersTests.swift |
Adds coverage for GitHub web URL construction. |
RxCode.xcodeproj/project.pbxproj |
Registers the new icon resource and updates app icon build settings. |
RxCode/Assets.xcassets/AppIcon.appiconset/Contents.json |
Removes the legacy app icon asset metadata. |
icon.icon/icon.json |
Adds Icon Composer icon metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+144
to
+145
| if let project = windowState.selectedProject, | ||
| let gitHubURL = ExternalEditorService.shared.gitHubURL(for: project) { |
| guard let urlString = String(data: data, encoding: .utf8)?.trimmingCharacters(in: .whitespacesAndNewlines), | ||
| !urlString.isEmpty else { return nil } | ||
|
|
||
| return parseGitHubOwnerRepo(from: urlString) |
Contributor
Author
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.