Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Replaces a hand-rolled markdown→HTML converter (and its dangerouslySetInnerHTML rendering) for GitHub release notes with react-markdown, fixing rendering issues for unsupported markdown constructs.
Changes:
- Adds
react-markdown@^10.1.0dependency (and its transitive deps) to the website package. - Removes the custom
escapeHtml/inlineMarkdownToHtml/releaseMarkdownToHtmlhelpers and surfaces the raw markdown via a newreleaseNotesMarkdownfield onAppReleaseNote. - Updates the release page to render notes through
<ReactMarkdown>with a custom<a>renderer that opens links in a new tab.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| website/package.json | Adds react-markdown dependency. |
| website/bun.lock | Locks react-markdown and its transitive dependencies. |
| website/app/lib/release.ts | Drops custom markdown→HTML conversion; exposes raw markdown via releaseNotesMarkdown and stops populating releaseNotesHtml for GitHub releases. |
| website/app/release/page.tsx | Renders release notes using ReactMarkdown with a custom anchor component instead of dangerouslySetInnerHTML. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+222
to
+232
| <ReactMarkdown | ||
| components={{ | ||
| a: ({ href, children }) => ( | ||
| <a href={href} target="_blank" rel="noreferrer"> | ||
| {children} | ||
| </a> | ||
| ), | ||
| }} | ||
| > | ||
| {release.releaseNotesMarkdown} | ||
| </ReactMarkdown> |
Comment on lines
+235
to
+236
| releaseNotesHtml: null, | ||
| releaseNotesMarkdown: release.body?.trim() || null, |
Contributor
Author
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.