feat: update website about acp clients#14
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR updates the marketing website and app UI to better reflect ACP (Agent Client Protocol) client support, adds a dedicated Release Notes page to the website, and introduces per-project model/provider defaults in the macOS app.
Changes:
- Website: add
/releasepage and supporting release-notes fetching/rendering + styling. - Website: update homepage/OG copy and feature cards to highlight ACP clients + registry install flow.
- App: add per-project model/provider persistence and update ACP settings UI navigation.
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| website/app/release/page.tsx | New Release Notes page UI rendering fetched release notes. |
| website/app/page.tsx | Marketing updates for ACP clients + feature layout changes; links now point to /release. |
| website/app/lib/release.ts | Adds GitHub releases list fetching + lightweight markdown-to-HTML conversion; introduces Sparkle parsing helpers. |
| website/app/lib/og-image.tsx | Updates OG description text to mention ACP clients. |
| website/app/globals.css | Adds .release-notes typographic styles for rendered release notes HTML. |
| RxCode/Views/Settings/ACPClientSettingsTab.swift | Adds segmented Installed/Registry navigation and lazy registry refresh. |
| RxCode/Views/MainView.swift | Uses AppState.effectiveModelSelection(in:) for model/provider display. |
| RxCode/App/AppState.swift | Adds per-project model/provider default selection logic and persistence. |
| README.md | Documentation updates to include ACP clients + registry installer. |
| Packages/Sources/RxCodeCore/Models/Project.swift | Persists per-project lastAgentProvider and lastModel. |
Comments suppressed due to low confidence (1)
RxCode/Views/MainView.swift:792
- Same as above:
effectiveModelSelection(in:)is computed twice foreffectiveModel/effectiveProvider, which repeats selection work on every render of this sheet. Compute once and reuse to keep SwiftUI updates cheaper.
private var effectiveModel: String { appState.effectiveModelSelection(in: windowState).model }
private var effectiveProvider: AgentProvider { appState.effectiveModelSelection(in: windowState).provider }
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
30
to
37
| type GitHubRelease = { | ||
| tag_name: string; | ||
| name: string; | ||
| html_url: string; | ||
| published_at: string; | ||
| body: string | null; | ||
| prerelease: boolean; | ||
| assets: GitHubAsset[]; |
Comment on lines
+210
to
+264
| function inlineMarkdownToHtml(value: string): string { | ||
| return escapeHtml(value) | ||
| .replace(/\*\*([^*]+)\*\*/g, "<strong>$1</strong>") | ||
| .replace(/`([^`]+)`/g, "<code>$1</code>"); | ||
| } | ||
|
|
||
| function releaseMarkdownToHtml(markdown: string): string { | ||
| const lines = markdown.split(/\r?\n/); | ||
| const html: string[] = []; | ||
| let inList = false; | ||
|
|
||
| const closeList = () => { | ||
| if (inList) { | ||
| html.push("</ul>"); | ||
| inList = false; | ||
| } | ||
| }; | ||
|
|
||
| for (const line of lines) { | ||
| const trimmed = line.trim(); | ||
| if (!trimmed) { | ||
| closeList(); | ||
| continue; | ||
| } | ||
|
|
||
| if (trimmed.startsWith("### ")) { | ||
| closeList(); | ||
| html.push(`<h3>${inlineMarkdownToHtml(trimmed.slice(4))}</h3>`); | ||
| continue; | ||
| } | ||
|
|
||
| if (trimmed.startsWith("## ")) { | ||
| closeList(); | ||
| html.push(`<h2>${inlineMarkdownToHtml(trimmed.slice(3))}</h2>`); | ||
| continue; | ||
| } | ||
|
|
||
| if (trimmed.startsWith("# ")) { | ||
| closeList(); | ||
| html.push(`<h2>${inlineMarkdownToHtml(trimmed.slice(2))}</h2>`); | ||
| continue; | ||
| } | ||
|
|
||
| if (trimmed.startsWith("- ")) { | ||
| if (!inList) { | ||
| html.push("<ul>"); | ||
| inList = true; | ||
| } | ||
| html.push(`<li>${inlineMarkdownToHtml(trimmed.slice(2))}</li>`); | ||
| continue; | ||
| } | ||
|
|
||
| closeList(); | ||
| html.push(`<p>${inlineMarkdownToHtml(trimmed)}</p>`); | ||
| } |
Comment on lines
+452
to
+453
| private var effectiveModel: String { appState.effectiveModelSelection(in: windowState).model } | ||
| private var effectiveProvider: AgentProvider { appState.effectiveModelSelection(in: windowState).provider } |
Comment on lines
+145
to
+151
| function extractHtmlBody(html: string): string { | ||
| const bodyMatch = html.match(/<body\b[^>]*>([\s\S]*?)<\/body>/i); | ||
| const inner = bodyMatch ? bodyMatch[1] : html; | ||
| return inner | ||
| .replace(/<script\b[\s\S]*?<\/script>/gi, "") | ||
| .replace(/<style\b[\s\S]*?<\/style>/gi, "") | ||
| .trim(); |
Comment on lines
+664
to
+717
| private func isModelAvailable(_ model: String, provider: AgentProvider) -> Bool { | ||
| availableAgentModelSections() | ||
| .flatMap(\.models) | ||
| .contains { $0.provider == provider && $0.id == model } | ||
| } | ||
|
|
||
| private func projectDefaultModelSelection(for project: Project?) -> (provider: AgentProvider, model: String)? { | ||
| guard let project, | ||
| let provider = project.lastAgentProvider, | ||
| let model = project.lastModel, | ||
| isModelAvailable(model, provider: provider) | ||
| else { | ||
| return nil | ||
| } | ||
| return (provider, model) | ||
| } | ||
|
|
||
| func defaultModelSelection(for project: Project?) -> (provider: AgentProvider, model: String) { | ||
| projectDefaultModelSelection(for: project) ?? (selectedAgentProvider, selectedModel) | ||
| } | ||
|
|
||
| func effectiveModelSelection(in window: WindowState) -> (provider: AgentProvider, model: String) { | ||
| if let provider = window.sessionAgentProvider, let model = window.sessionModel { | ||
| return (provider, model) | ||
| } | ||
| if let model = window.sessionModel { | ||
| return (window.sessionAgentProvider ?? selectedAgentProvider, model) | ||
| } | ||
| return defaultModelSelection(for: window.selectedProject) | ||
| } | ||
|
|
||
| private func rememberProjectModelSelection(_ model: String, provider: AgentProvider, in window: WindowState) { | ||
| guard let project = window.selectedProject, | ||
| let index = projects.firstIndex(where: { $0.id == project.id }) | ||
| else { | ||
| return | ||
| } | ||
|
|
||
| guard projects[index].lastAgentProvider != provider || projects[index].lastModel != model else { | ||
| return | ||
| } | ||
|
|
||
| projects[index].lastAgentProvider = provider | ||
| projects[index].lastModel = model | ||
| window.selectedProject = projects[index] | ||
|
|
||
| Task { | ||
| do { | ||
| try await persistence.saveProjects(projects) | ||
| } catch { | ||
| logger.error("Failed to save project model selection: \(error.localizedDescription)") | ||
| } | ||
| } | ||
| } |
Contributor
Author
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.