Add advisory for xml-rs Billion Laughs DoS via unbounded entity expansion#2670
Closed
BrianMcWilliams wants to merge 1 commit intorustsec:mainfrom
Closed
Add advisory for xml-rs Billion Laughs DoS via unbounded entity expansion#2670BrianMcWilliams wants to merge 1 commit intorustsec:mainfrom
BrianMcWilliams wants to merge 1 commit intorustsec:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This advisory reports a Denial of Service vulnerability in
xml-rsdue to unbounded entity expansion (Billion Laughs attack).Vulnerability:
xml-rsexpands internal DTD entity references recursively during parsing with no depth or size limit (CWE-776).Impact: A sub-1KB XML payload with recursively defined entities can expand to gigabytes of text (~3,000,000x amplification), causing exponential memory consumption and CPU exhaustion that crashes the process or host.
Affected: Any application using
xml-rsto parse untrusted XML input.Upstream issue: https://github.com/netvl/xml-rs/issues/new