Update all test certificates and add maintainence documentation#190
Merged
complexspaces merged 7 commits intomainfrom Aug 13, 2025
Merged
Update all test certificates and add maintainence documentation#190complexspaces merged 7 commits intomainfrom
complexspaces merged 7 commits intomainfrom
Conversation
Going forwards we will just use another pre-existing chain for unrelated name tests to reduce the maintainence burden. Given that, we don't need to keep this chain around or test that its valid for itself anymore.
33d916f to
b329fa6
Compare
djc
approved these changes
Aug 13, 2025
Member
djc
left a comment
There was a problem hiding this comment.
LGTM, thanks for getting this done!
Collaborator
Author
|
Thanks for the fast approval! Please bear with me as I get the various platform-specific compilation failures fixed 😅. |
b329fa6 to
52c9270
Compare
c1f1b3b to
ade5bb0
Compare
Collaborator
Author
Member
|
It seems reasonable-ish at least! |
ctz
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does several things, with the goal of both unbreaking CI today and making future maintenance easier. These include:
rustlsorg instead.my.1password.combecause it only supports TLS 1.3 by default. I could have just enabled thetls12feature but it seemed cleaner to just part with it and use a web server that has its TLS configurations updated more often.Commit-by-commit review is recommended.