Open
Conversation
|
|
||
| mod conversion; | ||
| #[cfg(feature = "num-traits")] | ||
| pub mod num_traits_impls; |
There was a problem hiding this comment.
Does the module need to be public? It just contains trait impls so nothing to export, right?
| #[test] | ||
| fn test_mul() { | ||
| assert_eq!(u1(1) * u1(1), u1(1)); | ||
| assert_eq!(u7(63) * u7(2), u7(126)); |
There was a problem hiding this comment.
Add a test for the overflowing, panic case?
BenLeadbetter
approved these changes
May 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found myself frequently wanting at least ONE and ZERO values from
num_traits, so I took a shot at implementing them here (this required implementingMulas well).I know there was some discussion/hesitation about implementing
num_traitshere, but this was so long ago now I'm thinking perhaps the concerns are no longer relevant.I did put the feature behind a flag and defaulted
num_traitsto not usingstdto maintain that aspect ofuX.