Skip to content

Make extended route types survive a parsing / serializing round trip#190

Open
jbruechert wants to merge 1 commit into
rust-transit:mainfrom
jbruechert:route-types-roundtrip
Open

Make extended route types survive a parsing / serializing round trip#190
jbruechert wants to merge 1 commit into
rust-transit:mainfrom
jbruechert:route-types-roundtrip

Conversation

@jbruechert

Copy link
Copy Markdown
Contributor

No description provided.

@jbruechert

Copy link
Copy Markdown
Contributor Author

ping

@Tristramg

Copy link
Copy Markdown
Collaborator

Hello, sorry for the long delay.

I agree that the current implementation looses information, and we should avoid that.

However, with the extended modes, maybe we should just natively store the number, without any matching, and have a categorized or simplified method as you did.
An other solution would be that each variant stores an integer. Wouldn’t it become cumbersome to use?

Both solutions would however be a breaking change. I’m a bit reluctant. Any opinion here @antoine-de

@jbruechert

Copy link
Copy Markdown
Contributor Author

I thought since this crate is still using 0ver this might be fine to have small breaking changes. We did it before with making route colours optional as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants