Open
Conversation
mattgathu
requested changes
Sep 5, 2018
Contributor
mattgathu
left a comment
There was a problem hiding this comment.
There is a binary file: src/bin/2 that is not required.
Your solution does not test the base case provided:
1! + 4! + 5! = 1 + 24 + 120 = 145.. Add a test for this base case.
Also you need to solve the main question:
Find the sum of all numbers which are equal to the sum of the factorial of their digits.
Contributor
…m of the factorial of their digits.
delete .rustc_info.json
Contributor
|
@maretekent maybe we need a test for A function that takes the number e.g. The test for this function will be something like this: #[test]
fn test_factorial_sum(){
assert_eq!(factorial_sum(145), 145);
}We can extrapolate this to an algorithm for finding the sum of all these numbers:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Solution Number: {34.rs}
Checklist:
src/binWhat
Find the sum of all numbers which are equal to the sum of the factorial of their digits.
145 is an interesting number, as 1! + 4! + 5! = 1 + 24 + 120 = 145.
Note: as 1! = 1 and 2! = 2 are not sums they are not included.
How
Solution
Nice to have:
I would have loved to iterate over the characters of string and convert and add them using fold
Challenges
You are attempting to multiply with overflowRef
Project Euler problem 34
Issue 34