Update Cargo submodule by alexcrichton · Pull Request #48549 · rust-lang/rust

alexcrichton · 2018-02-26T17:09:59Z

Hopefully a routine update...

rust-highfive · 2018-02-26T17:10:14Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

Mark-Simulacrum

r=me if you have a solution for the problem I've noted

Mark-Simulacrum · 2018-02-26T18:15:13Z

src/Cargo.lock

This'll break some of our tests IIRC so we'll need to not do this until we can get rid of one of the rands or remove extern crate rand from the tests.

alexcrichton · 2018-02-26T22:52:59Z

@bors: r=Mark-Simulacrum

bors · 2018-02-26T22:52:59Z

📌 Commit 3075dad has been approved by Mark-Simulacrum

alexcrichton · 2018-02-26T22:57:34Z

@bors: r=Mark-Simulacrum

bors · 2018-02-26T22:57:35Z

📌 Commit 45045d0 has been approved by Mark-Simulacrum

nikomatsakis · 2018-02-27T18:51:13Z

r? @Mark-Simulacrum

bors · 2018-03-01T05:07:23Z

☔ The latest upstream changes (presumably #48349) made this pull request unmergeable. Please resolve the merge conflicts.

alexcrichton · 2018-03-01T05:45:23Z

@bors: r=Mark-Simulacrum

bors · 2018-03-01T05:45:24Z

📌 Commit 842ced5 has been approved by Mark-Simulacrum

Manishearth · 2018-03-02T09:03:59Z

@bors p=2

prioritizing risky-to-rollup PRs so they get tested first

bors · 2018-03-02T10:10:33Z

🔒 Merge conflict

alexcrichton · 2018-03-02T15:19:13Z

@bors: r=Mark-Simulacrum

bors · 2018-03-02T15:19:16Z

📌 Commit ac0a2a7 has been approved by Mark-Simulacrum

bors · 2018-03-08T01:06:38Z

📌 Commit 255ecf6 has been approved by Mark-Simulacrum

alexcrichton · 2018-03-08T01:14:25Z

@bors: r=Mark-Simulacrum

bors · 2018-03-08T01:14:26Z

📌 Commit 729905d has been approved by Mark-Simulacrum

alexcrichton · 2018-03-08T01:23:09Z

@bors: r=Mark-Simulacrum

bors · 2018-03-08T01:23:09Z

📌 Commit c060369 has been approved by Mark-Simulacrum

bors · 2018-03-08T07:31:14Z

⌛ Testing commit c0603695225cb4d9f01eafc06b97728be1389180 with merge b91dd6daa8a1327fc870159c0c1c6aed708aa3f0...

bors · 2018-03-08T08:52:19Z

💔 Test failed - status-travis

kennytm · 2018-03-08T09:10:36Z

Unused imports.

[01:16:36] Libstd was built without `wasm_syscall` feature enabled: test output may not be visible.
[01:16:37]    Compiling rand v0.4.2
[01:16:39]    Compiling core v0.0.0 (file:///checkout/src/libcore)
[01:16:41] error: unused imports: `Equal`, `Greater`, `Less`
[01:16:41]   --> libcore/../libcore/tests/slice.rs:12:27
[01:16:41]    |
[01:16:41] 12 | use core::cmp::Ordering::{Equal, Greater, Less};
[01:16:41]    |                           ^^^^^  ^^^^^^^  ^^^^
[01:16:41]    |
[01:16:41] note: lint level defined here
[01:16:41]   --> libcore/../libcore/tests/lib.rs:11:9
[01:16:41]    |
[01:16:41] 11 | #![deny(warnings)]
[01:16:41]    |         ^^^^^^^^
[01:16:41]    = note: #[deny(unused_imports)] implied by #[deny(warnings)]
[01:16:41]
[01:16:41] error: unused import: `core::slice::heapsort`
[01:16:41]   --> libcore/../libcore/tests/slice.rs:13:5
[01:16:41]    |
[01:16:41] 13 | use core::slice::heapsort;
[01:16:41]    |     ^^^^^^^^^^^^^^^^^^^^^
[01:16:41]
[01:16:41] error: unused imports: `Rng`, `XorShiftRng`
[01:16:41]   --> libcore/../libcore/tests/slice.rs:15:12
[01:16:41]    |
[01:16:41] 15 | use rand::{Rng, XorShiftRng};
[01:16:41]    |            ^^^  ^^^^^^^^^^^
[01:16:41]
[01:16:55] error: aborting due to 3 previous errors
[01:16:55]
[01:16:55] error: Could not compile `core`.

alexcrichton · 2018-03-08T15:33:18Z

@bors: r=Mark-Simulacrum

bors · 2018-03-08T15:33:18Z

📌 Commit 0748af2 has been approved by Mark-Simulacrum

bors · 2018-03-09T14:48:20Z

🔒 Merge conflict

alexcrichton · 2018-03-09T15:26:49Z

@bors: r=Mark-Simulacrum

bors · 2018-03-09T15:26:50Z

📌 Commit df84987 has been approved by Mark-Simulacrum

alexcrichton · 2018-03-09T19:40:54Z

@bors: r=Mark-Simulacrum

bors · 2018-03-09T19:40:55Z

📌 Commit 62a8f7d has been approved by Mark-Simulacrum

bors · 2018-03-11T02:04:22Z

⌛ Testing commit 62a8f7d with merge e1999a6...

bors · 2018-03-11T04:34:05Z

💔 Test failed - status-travis

kennytm · 2018-03-11T08:17:44Z

asmjs failed at slice::panic_safe.

Details

[02:22:46] failures:
[02:22:46] 
[02:22:46] ---- slice::panic_safe stdout ----
[02:22:46] 	thread 'main' panicked at 'explicit panic', libstd/sys/unix/thread.rs:48:5
[02:22:46] 
[02:22:46] 
[02:22:46] failures:
[02:22:46]     slice::panic_safe
[02:22:46] 
[02:22:46] test result: FAILED. 479 passed; 1 failed; 1 ignored; 0 measured; 0 filtered out
[02:22:46] 
[02:22:46] �[m�[m�[31m�[1merror:�[m test failed, to rerun pass '--test collectionstests'

Required moving all fulldeps tests depending on `rand` to different locations as now there's multiple `rand` crates that can't be implicitly linked against.

alexcrichton · 2018-03-11T17:59:46Z

@bors: r=Mark-Simulacrum

bors · 2018-03-11T17:59:46Z

📌 Commit 994bfd4 has been approved by Mark-Simulacrum

kennytm · 2018-03-11T19:11:10Z

@bors p=2

bors · 2018-03-11T20:28:40Z

⌛ Testing commit 994bfd4 with merge 178becd...

bors · 2018-03-11T23:08:41Z

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing 178becd to master...

rust-highfive assigned nikomatsakis Feb 26, 2018

emilyalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 26, 2018

Mark-Simulacrum approved these changes Feb 26, 2018

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2018

alexcrichton force-pushed the update-cargo branch from 3075dad to 45045d0 Compare February 26, 2018 22:57

rust-highfive assigned Mark-Simulacrum and unassigned nikomatsakis Feb 27, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 1, 2018

alexcrichton force-pushed the update-cargo branch from 45045d0 to 842ced5 Compare March 1, 2018 05:45

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 1, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 2, 2018

alexcrichton force-pushed the update-cargo branch from 842ced5 to ac0a2a7 Compare March 2, 2018 15:19

bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 2, 2018

Mark-Simulacrum mentioned this pull request Mar 10, 2018

Rollup of 7 pull requests #48912

Closed

Update Cargo submodule

994bfd4

Required moving all fulldeps tests depending on `rand` to different locations as now there's multiple `rand` crates that can't be implicitly linked against.

Uh oh!

Conversation

alexcrichton commented Feb 26, 2018

Uh oh!

rust-highfive commented Feb 26, 2018

Uh oh!

Mark-Simulacrum left a comment

Choose a reason for hiding this comment

Uh oh!

Mark-Simulacrum Feb 26, 2018

Choose a reason for hiding this comment

Uh oh!

alexcrichton commented Feb 26, 2018

Uh oh!

bors commented Feb 26, 2018

Uh oh!

alexcrichton commented Feb 26, 2018

Uh oh!

bors commented Feb 26, 2018

Uh oh!

nikomatsakis commented Feb 27, 2018

Uh oh!

bors commented Mar 1, 2018

Uh oh!

alexcrichton commented Mar 1, 2018

Uh oh!

bors commented Mar 1, 2018

Uh oh!

Manishearth commented Mar 2, 2018

Uh oh!

bors commented Mar 2, 2018

Uh oh!

alexcrichton commented Mar 2, 2018

Uh oh!

bors commented Mar 2, 2018

Uh oh!

bors commented Mar 8, 2018

Uh oh!

alexcrichton commented Mar 8, 2018

Uh oh!

bors commented Mar 8, 2018

Uh oh!

alexcrichton commented Mar 8, 2018

Uh oh!

bors commented Mar 8, 2018

Uh oh!

bors commented Mar 8, 2018

Uh oh!

bors commented Mar 8, 2018

Uh oh!

kennytm commented Mar 8, 2018

Uh oh!

alexcrichton commented Mar 8, 2018

Uh oh!

bors commented Mar 8, 2018

Uh oh!

bors commented Mar 9, 2018

Uh oh!

alexcrichton commented Mar 9, 2018

Uh oh!

bors commented Mar 9, 2018

Uh oh!

alexcrichton commented Mar 9, 2018

Uh oh!

bors commented Mar 9, 2018

Uh oh!

bors commented Mar 11, 2018

Uh oh!

bors commented Mar 11, 2018

Uh oh!

kennytm commented Mar 11, 2018

Uh oh!

alexcrichton commented Mar 11, 2018

Uh oh!

bors commented Mar 11, 2018

Uh oh!

kennytm commented Mar 11, 2018

Uh oh!

bors commented Mar 11, 2018

Uh oh!