Skip to content

Improve the inline_fluent! macro#152356

Open
JonathanBrouwer wants to merge 2 commits intorust-lang:mainfrom
JonathanBrouwer:inline_diag4
Open

Improve the inline_fluent! macro#152356
JonathanBrouwer wants to merge 2 commits intorust-lang:mainfrom
JonathanBrouwer:inline_diag4

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Feb 8, 2026 •
edited
Loading

For #151366

This PR turns inline_fluent! into a proc macro, so we can run validation on the messages in this macro :)
I started a thread here because I don't like the name of the macro, but that's for a future PR: #t-compiler > Bikeshed the new `inline_fluent!` macro

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 8, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 8, 2026
Open
3 tasks
@JonathanBrouwer JonathanBrouwer changed the title Improve the inline_fluent! macro and rename it to msg! Improve the inline_fluent! macro Feb 8, 2026
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Feb 8, 2026

r? @jdonszelmann

@JonathanBrouwer JonathanBrouwer marked this pull request as ready for review February 8, 2026 21:47
@rustbot
Copy link
Collaborator

rustbot commented Feb 8, 2026

rustc_errors::translation was changed

cc @davidtwco, @TaKO8Ki

rustc_macros::diagnostics was changed

cc @davidtwco, @TaKO8Ki

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 8, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 8, 2026
Merged
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Feb 8, 2026

Don't merge together with #152276, these will soft-conflict

@jdonszelmann
Copy link
Contributor

jdonszelmann commented Feb 9, 2026

don't merge, #152276 goes first

@rustbot
Copy link
Collaborator

rustbot commented Feb 9, 2026

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

@rustbot
Copy link
Collaborator

rustbot commented Feb 9, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Feb 9, 2026 •
edited
Loading

Soft conflict is now resolved, safe to merge :)
@jdonszelmann I don't think you reviewed this yet, right?
The new diff is only reformatting of messages due to #152276

@rust-log-analyzer

This comment was marked as outdated.

Sign in to view
2 similar comments
@rust-log-analyzer

This comment was marked as outdated.

Sign in to view
@rust-log-analyzer

This comment was marked as outdated.

Sign in to view
@jdonszelmann
Copy link
Contributor

jdonszelmann commented Feb 13, 2026

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 13, 2026

📌 Commit 6eb2a8f has been approved by jdonszelmann

It is now in the queue for this repository.

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 13, 2026
@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 13, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 13, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152356 - JonathanBrouwer:inline_diag4, r=jd…
db9c339 
…onszelmann

Improve the `inline_fluent!` macro

For rust-lang#151366

This PR turns `inline_fluent!` into a proc macro, so we can run validation on the messages in this macro :)
I started a thread here because I don't like the name of the macro, but that's for a future PR: [#t-compiler > Bikeshed the new &rust-lang#96;inline_fluent!&rust-lang#96; macro](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Bikeshed.20the.20new.20.60inline_fluent!.60.20macro/with/572646242)
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 13, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 13, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152356 - JonathanBrouwer:inline_diag4, r=jd…
1ca967f 
…onszelmann

Improve the `inline_fluent!` macro

For rust-lang#151366

This PR turns `inline_fluent!` into a proc macro, so we can run validation on the messages in this macro :)
I started a thread here because I don't like the name of the macro, but that's for a future PR: [#t-compiler > Bikeshed the new &rust-lang#96;inline_fluent!&rust-lang#96; macro](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Bikeshed.20the.20new.20.60inline_fluent!.60.20macro/with/572646242)
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 13, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 13, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152356 - JonathanBrouwer:inline_diag4, r=jd…
f1b935d 
…onszelmann

Improve the `inline_fluent!` macro

For rust-lang#151366

This PR turns `inline_fluent!` into a proc macro, so we can run validation on the messages in this macro :)
I started a thread here because I don't like the name of the macro, but that's for a future PR: [#t-compiler > Bikeshed the new &rust-lang#96;inline_fluent!&rust-lang#96; macro](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Bikeshed.20the.20new.20.60inline_fluent!.60.20macro/with/572646242)
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 13, 2026
Open
rust-bors bot pushed a commit that referenced this pull request Feb 13, 2026
@bors
Auto merge of #152574 - JonathanBrouwer:rollup-ERc05AE, r=JonathanBro…
a05d1cd 
…uwer

Rollup of 14 pull requests

Successful merges:

 - #152323 (Fix ICE in borrowck when recovering `fn_sig` for `-> _`)
 - #152469 (Remove unused features)
 - #152515 (Extract `DepKindVTable` constructors to their own module)
 - #152555 (Port `#[rustc_diagnostic_item]` to the new attribute parsers)
 - #152218 (Report unconstrained region in hidden types lazily)
 - #152356 (Improve the `inline_fluent!` macro)
 - #152392 (Fix ICE in supertrait_vtable_slot when supertrait has missing generics)
 - #152407 (Add regression test for type_const with unit struct ctor under mGCA)
 - #152440 (Fix typos and grammar in compiler and build documentation)
 - #152536 (bootstrap: add explicit UTF-8 encoding to text-mode open() calls)
 - #152554 (Remove `deprecated_safe` and its corresponding feature gate)
 - #152556 (doc: move riscv64a23-unknown-linux-gnu to tier 2)
 - #152563 (Replace "bug" with "issue" in triagebot ping messages)
 - #152565 (fix missleading error for tuple ctor)

Failed merges:

 - #152512 (core: Implement feature `float_exact_integer_constants`)
 - #152296 (Port `rust_nonnull_optimization_guaranteed` and `rustc_do_not_const_check` to the new attribute parser)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jdonszelmann jdonszelmann

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JonathanBrouwer @rustbot @jdonszelmann @rust-log-analyzer