-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
Support ADT types in type info reflection #151142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
1bd8449 to
0b20893
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
0b20893 to
e50e5d9
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
e50e5d9 to
0b7ff30
Compare
|
Is there anything missing from this PR / is there some way I could help? @SpriteOvO |
|
I've almost finished it locally, but there's still some cleanup and rebasing I need to do before it's ready for review. Just been a bit busy lately. |
|
@SpriteOvO Btw traits are already done in the other PR and unions / methods seem out of scope of ADTs so consider omiting them from this PR |
c5e6c84 to
f0ae098
Compare
This comment has been minimized.
This comment has been minimized.
f0ae098 to
ffabe32
Compare
Support ADT types in type info reflection Tracking issue: rust-lang#146922 `#![feature(type_info)]` This PR supports ADT types for feature `type_info` reflection. (It's still a draft PR, with implementation in progress) Note that this PR does not take SemVer into consideration (I left a FIXME comment). As discussed earlier ([comment](rust-lang#146923 (comment))), this requires further discussion. However, I hope we could get an initial implementation to land first, so we can start playing with it. ### Progress / Checklist - [x] Struct support. - [x] Enum - [x] Union - [x] Generics - [ ] ~Methods~ Implemented and to be implemented in other PRs - [ ] ~Traits~ Implemented and to be implemented in other PRs - [x] Rebasing PR to `main` branch ~~(It's currently based on PR rust-lang#151123, so here's an extra commit)~~ - [x] Cleanup and Rebase. - [x] Fix field info for references. (see [comment](rust-lang#151142 (comment))) r? @oli-obk
Support ADT types in type info reflection Tracking issue: rust-lang#146922 `#![feature(type_info)]` This PR supports ADT types for feature `type_info` reflection. (It's still a draft PR, with implementation in progress) Note that this PR does not take SemVer into consideration (I left a FIXME comment). As discussed earlier ([comment](rust-lang#146923 (comment))), this requires further discussion. However, I hope we could get an initial implementation to land first, so we can start playing with it. ### Progress / Checklist - [x] Struct support. - [x] Enum - [x] Union - [x] Generics - [ ] ~Methods~ Implemented and to be implemented in other PRs - [ ] ~Traits~ Implemented and to be implemented in other PRs - [x] Rebasing PR to `main` branch ~~(It's currently based on PR rust-lang#151123, so here's an extra commit)~~ - [x] Cleanup and Rebase. - [x] Fix field info for references. (see [comment](rust-lang#151142 (comment))) r? @oli-obk
…uwer Rollup of 13 pull requests Successful merges: - #149937 (try enabling `linker-messages` by default again) - #151733 (Use function shims to make sure EII works on apple targets) - #152120 (Don't ICE on layout error in vtable computation) - #152419 (Move more query system code) - #152431 (Restrict the set of things that const stability can be applied to) - #152436 (Reenable a GCI+mGCA+GCPT test case) - #151142 (Support ADT types in type info reflection) - #152021 (Bump tvOS, visionOS and watchOS Aarch64 targets to tier 2) - #152146 (mGCA: Add associated const type check) - #152372 (style: remove unneeded trailing commas) - #152383 (BikeshedGuaranteedNoDrop trait: add comments indicating that it can be observed on stable) - #152397 (Update books) - #152441 (Fix typos and grammar in top-level and src/doc documentation)
Support ADT types in type info reflection Tracking issue: rust-lang#146922 `#![feature(type_info)]` This PR supports ADT types for feature `type_info` reflection. (It's still a draft PR, with implementation in progress) Note that this PR does not take SemVer into consideration (I left a FIXME comment). As discussed earlier ([comment](rust-lang#146923 (comment))), this requires further discussion. However, I hope we could get an initial implementation to land first, so we can start playing with it. ### Progress / Checklist - [x] Struct support. - [x] Enum - [x] Union - [x] Generics - [ ] ~Methods~ Implemented and to be implemented in other PRs - [ ] ~Traits~ Implemented and to be implemented in other PRs - [x] Rebasing PR to `main` branch ~~(It's currently based on PR rust-lang#151123, so here's an extra commit)~~ - [x] Cleanup and Rebase. - [x] Fix field info for references. (see [comment](rust-lang#151142 (comment))) r? @oli-obk
Support ADT types in type info reflection Tracking issue: rust-lang#146922 `#![feature(type_info)]` This PR supports ADT types for feature `type_info` reflection. (It's still a draft PR, with implementation in progress) Note that this PR does not take SemVer into consideration (I left a FIXME comment). As discussed earlier ([comment](rust-lang#146923 (comment))), this requires further discussion. However, I hope we could get an initial implementation to land first, so we can start playing with it. ### Progress / Checklist - [x] Struct support. - [x] Enum - [x] Union - [x] Generics - [ ] ~Methods~ Implemented and to be implemented in other PRs - [ ] ~Traits~ Implemented and to be implemented in other PRs - [x] Rebasing PR to `main` branch ~~(It's currently based on PR rust-lang#151123, so here's an extra commit)~~ - [x] Cleanup and Rebase. - [x] Fix field info for references. (see [comment](rust-lang#151142 (comment))) r? @oli-obk
|
@oli-obk I think we should probably drop the I'll confirm later whether a follow-up PR is necessary to further refine the existing |
627a1f1 to
4810270
Compare
|
Yea. dump.rs was never a good idea I had. Just an easy thing. There's enough other tests, so let's nuke it |
|
@rustbot review |
|
@bors r+ |
Support ADT types in type info reflection Tracking issue: rust-lang#146922 `#![feature(type_info)]` This PR supports ADT types for feature `type_info` reflection. (It's still a draft PR, with implementation in progress) Note that this PR does not take SemVer into consideration (I left a FIXME comment). As discussed earlier ([comment](rust-lang#146923 (comment))), this requires further discussion. However, I hope we could get an initial implementation to land first, so we can start playing with it. ### Progress / Checklist - [x] Struct support. - [x] Enum - [x] Union - [x] Generics - [ ] ~Methods~ Implemented and to be implemented in other PRs - [ ] ~Traits~ Implemented and to be implemented in other PRs - [x] Rebasing PR to `main` branch ~~(It's currently based on PR rust-lang#151123, so here's an extra commit)~~ - [x] Cleanup and Rebase. - [x] Fix field info for references. (see [comment](rust-lang#151142 (comment))) r? @oli-obk
Rollup of 7 pull requests Successful merges: - #152505 (Sync relnotes for stable 1.93.1) - #137487 (Stabilize `assert_matches`) - #152281 (borrowck: suggest `&mut *x` for pattern reborrows) - #151142 (Support ADT types in type info reflection) - #152477 (rustc-dev-guide subtree update) - #152488 (allow `deprecated(since = "CURRENT_RUSTC_VERSION")`) - #152491 (Remove unused `fluent-syntax` dependency from tidy)
Tracking issue: #146922
#![feature(type_info)]This PR supports ADT types for feature
type_inforeflection.(It's still a draft PR, with implementation in progress)
Note that this PR does not take SemVer into consideration (I left a FIXME comment). As discussed earlier (comment), this requires further discussion. However, I hope we could get an initial implementation to land first, so we can start playing with it.
Progress / Checklist
MethodsImplemented and to be implemented in other PRsTraitsImplemented and to be implemented in other PRsmainbranch(It's currently based on PR Support primitives in type info reflection #151123, so here's an extra commit)r? @oli-obk