Move std_detect tests into a separate crate#150813
Move std_detect tests into a separate crate#150813bjorn3 wants to merge 3 commits intorust-lang:mainfrom
Conversation
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
|
r? @clubby789 rustbot has assigned @clubby789. Use |
This comment has been minimized.
This comment has been minimized.
9da3959 to
2aef964
Compare
|
Bootstrap changes look fine to me, so r? libs |
This comment has been minimized.
This comment has been minimized.
|
r? libs |
2aef964 to
bc1d73e
Compare
This comment has been minimized.
This comment has been minimized.
1013779 to
c18ed7b
Compare
This comment has been minimized.
This comment has been minimized.
|
To make sure things still build on some of the targets here @bors try jobs=test-various |
This comment has been minimized.
This comment has been minimized.
Move std_detect tests into a separate crate try-job: test-various
|
Bootstrap changes look straightforward, and I don't see any special handling for coretests/alloctests that has been missed for std_detect_tests, so r=me on that front. r? tgross35 |
|
Commit bc56f5d has been unapproved. |
|
@matthiaskrgr which rollup did this PR fail in? #151609 failed on another PR. #151614 passed CI, but got closed before bors tested it. |
|
it was a local build |
|
What configuration? |
|
@bors r+ rollup=never May as well find out |
This comment has been minimized.
This comment has been minimized.
Move std_detect tests into a separate crate Same rationale as #136642.
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 4c08d8b failed: CI. Failed job:
|
|
@rustbot author |
bc56f5d to
ca8d372
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@bors try jobs=x86_64-gnu-llvm-21-3 |
This comment has been minimized.
This comment has been minimized.
Move std_detect tests into a separate crate try-job: x86_64-gnu-llvm-21-3
|
💔 Test for 3d09ab0 failed: CI. Failed job:
|
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
☔ The latest upstream changes (presumably #152574) made this pull request unmergeable. Please resolve the merge conflicts. |
Same rationale as #136642.