Fix for pattern types causing ICE in debuginfo generation#145716
Draft
notJoon wants to merge 2 commits intorust-lang:mainfrom
Draft
Fix for pattern types causing ICE in debuginfo generation#145716notJoon wants to merge 2 commits intorust-lang:mainfrom
debuginfo generation#145716notJoon wants to merge 2 commits intorust-lang:mainfrom
Conversation
rustbot
added
A-LLVM
This comment has been minimized.
This comment has been minimized.
Contributor
|
☔ The latest upstream changes (presumably #148537) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #145514 where pattern types would cause an ICE when generating debug info. The issue was that the compiler didn't know how to handle
ty::Pattypes in the debuginfo metadata generation.The pattern types are refinement types that have the same runtim representation as their underlying type, so I just generate a
typedefin the debuginfo that points to the inner type but uses the pattern type's name. It would give debuggers the right information.