Use `mem::take` instead of `mem::replace` when applicable by krishna-veerareddy · Pull Request #4881 · rust-lang/rust-clippy

krishna-veerareddy · 2019-12-04T21:22:49Z

std::mem::take can be used to replace a value of type T with T::default() instead of std::mem::replace.

Fixes issue #4871

changelog: Added lint for [mem_replace_with_default]

tests/ui/mem_replace.rs

krishna-veerareddy · 2019-12-09T01:51:17Z

@lzutao Hey I added checks so that it doesn't lint within macros. Also added some macro test cases to prevent regressions in the future.

clippy_lints/src/mem_replace.rs

bors · 2019-12-21T19:59:43Z

☔ The latest upstream changes (presumably #4932) made this pull request unmergeable. Please resolve the merge conflicts.

flip1995

LGTM! Linting in internal macros would be good though. On how to test this see my comment #4881 (comment)

clippy_lints/src/mem_replace.rs

flip1995 · 2019-12-22T10:18:15Z

And sorry for the late reply, I was on vacation.

clippy_lints/src/mem_replace.rs

tesuji · 2019-12-22T17:41:45Z

If you change

-            if func_args.len() == 2;
+            if let [dest, src] = &**func_args;

tests/ui/mem_replace_macro.rs

flip1995 · 2019-12-28T11:57:47Z

@bors r+

Thanks!

bors · 2019-12-28T11:57:48Z

📌 Commit aca6815 has been approved by flip1995

bors · 2019-12-28T11:57:55Z

⌛ Testing commit aca6815 with merge 31eb751...

…lip1995 Use `mem::take` instead of `mem::replace` when applicable `std::mem::take` can be used to replace a value of type `T` with `T::default()` instead of `std::mem::replace`. Fixes issue #4871 changelog: Added lint for [`mem_replace_with_default`]

bors · 2019-12-28T12:12:21Z

💔 Test failed - checks-travis

flip1995 · 2019-12-28T12:13:03Z

Expr -> Expr<'_>

krishna-veerareddy · 2019-12-29T17:01:40Z

@bors retry

bors · 2019-12-29T17:01:41Z

@krishna-veerareddy: 🔑 Insufficient privileges: not in try users

krishna-veerareddy · 2019-12-29T17:03:31Z

@flip1995 Hey I added the rustup fixes. Please review.

flip1995 · 2019-12-30T00:45:55Z

@bors r+

Thanks!

bors · 2019-12-30T00:45:56Z

📌 Commit 45e7b87 has been approved by flip1995

bors · 2019-12-30T00:46:04Z

⌛ Testing commit 45e7b87 with merge 0950766...

…lip1995 Use `mem::take` instead of `mem::replace` when applicable `std::mem::take` can be used to replace a value of type `T` with `T::default()` instead of `std::mem::replace`. Fixes issue #4871 changelog: Added lint for [`mem_replace_with_default`]

bors · 2019-12-30T00:50:15Z

💔 Test failed - status-appveyor

krishna-veerareddy · 2019-12-30T14:34:01Z

@flip1995 @phansch Hey there was another rustup fix required so rebased again.

`std::mem::take` can be used to replace a value of type `T` with `T::default()` instead of `std::mem::replace`.

Also added test cases for internal and external macros.

krishna-veerareddy · 2019-12-31T17:40:09Z

@phansch @flip1995 Rebased after rustup. Please review when you have some time. Thanks!

phansch · 2020-01-04T07:45:08Z

@bors r=flip1995

bors · 2020-01-04T07:45:09Z

📌 Commit 42e4595 has been approved by flip1995

bors · 2020-01-04T08:09:48Z

⌛ Testing commit 42e4595 with merge fa9b85d...

…lip1995 Use `mem::take` instead of `mem::replace` when applicable `std::mem::take` can be used to replace a value of type `T` with `T::default()` instead of `std::mem::replace`. Fixes issue #4871 changelog: Added lint for [`mem_replace_with_default`]

bors · 2020-01-04T08:39:54Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing fa9b85d to master...

krishna-veerareddy changed the title ~~Use mem::take instead of mem::replace when applicable~~ [WIP] Use mem::take instead of mem::replace when applicable Dec 4, 2019

krishna-veerareddy force-pushed the issue-4871-use-mem-take branch from 401b3d1 to 64855de Compare December 4, 2019 21:39

krishna-veerareddy changed the title ~~[WIP] Use mem::take instead of mem::replace when applicable~~ Use mem::take instead of mem::replace when applicable Dec 4, 2019

flip1995 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties A-lint Area: New lints labels Dec 5, 2019

krishna-veerareddy force-pushed the issue-4871-use-mem-take branch 2 times, most recently from 0f6b46c to 38bb08d Compare December 8, 2019 03:10

tesuji reviewed Dec 8, 2019

View reviewed changes

tests/ui/mem_replace.rs Show resolved Hide resolved

tesuji reviewed Dec 8, 2019

View reviewed changes

tests/ui/mem_replace.rs Show resolved Hide resolved

tests/ui/mem_replace.rs Show resolved Hide resolved

krishna-veerareddy mentioned this pull request Dec 8, 2019

add tests for using macros in as_conversions_lint #4888

Closed

tesuji reviewed Dec 9, 2019

View reviewed changes

clippy_lints/src/mem_replace.rs Show resolved Hide resolved

krishna-veerareddy requested a review from flip1995 December 16, 2019 19:34

krishna-veerareddy force-pushed the issue-4871-use-mem-take branch from 8a27af3 to 5c225e1 Compare December 19, 2019 06:16

flip1995 approved these changes Dec 22, 2019

View reviewed changes

clippy_lints/src/mem_replace.rs Outdated Show resolved Hide resolved

krishna-veerareddy force-pushed the issue-4871-use-mem-take branch from 5c225e1 to 38e7bd2 Compare December 22, 2019 16:17

tesuji reviewed Dec 22, 2019

View reviewed changes

This comment has been minimized.

Sign in to view

krishna-veerareddy force-pushed the issue-4871-use-mem-take branch 2 times, most recently from 8d1f0fc to 5d8366f Compare December 24, 2019 16:01

tesuji reviewed Dec 24, 2019

View reviewed changes

tests/ui/mem_replace_macro.rs Outdated Show resolved Hide resolved

krishna-veerareddy force-pushed the issue-4871-use-mem-take branch from aca6815 to 36cea1c Compare December 29, 2019 16:58

krishna-veerareddy force-pushed the issue-4871-use-mem-take branch from 36cea1c to 45e7b87 Compare December 29, 2019 18:06

krishna-veerareddy force-pushed the issue-4871-use-mem-take branch from 45e7b87 to f1e22c8 Compare December 30, 2019 14:21

krishna-veerareddy added 8 commits December 31, 2019 09:22

Use mem::take instead of mem::replace when applicable

8db319f

`std::mem::take` can be used to replace a value of type `T` with `T::default()` instead of `std::mem::replace`.

Add test cases for replace with Default::default()

2a75241

Prevent mem_replace_with_default lint within macros

26812f7

Also added test cases for internal and external macros.

Move mem_replace_with_default out of nursery

78b4dfc

Destructure mem:replace arguments

aa66f76

Lint within internal macros without a suggestion

c09e79e

Remove unnecessary import

a8413a3

Indicate anonymous lifetimes for types

42e4595

krishna-veerareddy force-pushed the issue-4871-use-mem-take branch from f1e22c8 to 42e4595 Compare December 31, 2019 17:28

bors merged commit 42e4595 into rust-lang:master Jan 4, 2020

bors mentioned this pull request Jan 4, 2020

New lint: pats_with_wild_match_arm #4960

Merged

krishna-veerareddy mentioned this pull request Jan 4, 2020

New lint: Suggest usage of mem::take #4871

Closed

Conversation

krishna-veerareddy commented Dec 4, 2019 • edited by flip1995 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

krishna-veerareddy commented Dec 9, 2019

Uh oh!

Uh oh!

bors commented Dec 21, 2019

Uh oh!

flip1995 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

flip1995 commented Dec 22, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tesuji commented Dec 22, 2019

Uh oh!

This comment has been minimized.

Uh oh!

flip1995 commented Dec 28, 2019

Uh oh!

bors commented Dec 28, 2019

Uh oh!

bors commented Dec 28, 2019

Uh oh!

bors commented Dec 28, 2019

Uh oh!

flip1995 commented Dec 28, 2019

Uh oh!

krishna-veerareddy commented Dec 29, 2019

Uh oh!

bors commented Dec 29, 2019

Uh oh!

krishna-veerareddy commented Dec 29, 2019

Uh oh!

flip1995 commented Dec 30, 2019

Uh oh!

bors commented Dec 30, 2019

Uh oh!

bors commented Dec 30, 2019

Uh oh!

bors commented Dec 30, 2019

Uh oh!

krishna-veerareddy commented Dec 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

krishna-veerareddy commented Dec 31, 2019

Uh oh!

phansch commented Jan 4, 2020

Uh oh!

bors commented Jan 4, 2020

Uh oh!

bors commented Jan 4, 2020

Uh oh!

bors commented Jan 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

krishna-veerareddy commented Dec 4, 2019 •

edited by flip1995

Loading

flip1995 left a comment •

edited

Loading

krishna-veerareddy commented Dec 30, 2019 •

edited

Loading