Add the inlined_generics lint.#10650
Closed
nullptrderef29 wants to merge 1 commit intorust-lang:masterfrom
nullptrderef29:inlined_generics
Closed
Add the inlined_generics lint.#10650nullptrderef29 wants to merge 1 commit intorust-lang:masterfrom nullptrderef29:inlined_generics
inlined_generics lint.#10650nullptrderef29 wants to merge 1 commit intorust-lang:masterfrom
nullptrderef29:inlined_generics
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
the
S-waiting-on-review
functions/methods with generics which are also marked either `#[inline]` or `#[inline(always)]`.
Contributor
|
☔ The latest upstream changes (presumably #10578) made this pull request unmergeable. Please resolve the merge conflicts. |
flip1995
added
S-inactive-closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
inlined_genericslint, which lints generic functions/methods that are marked#[inline]or#[inline(always)], as doing so can possibly increase compilation times, because the compiler will monomorphize all generic functions per crate as well as recompiling a function marked#[inline]or#[inline(always)]per CGU. See also this comment as well as this comment for some more information.changelog: new lint: [
inlined_generics]