Various fixes to the file related shims

[pvdrz]

Hi @RalfJung, I'll be working incrementally over your comments for the new fs shims module here.

[RalfJung]

Could you also rename the "file_manipulation.rs" test to "fs.rs"? That corresponds with the libstd module it tests.

[pvdrz]

I think we should stop this PR here and review that all the changes are adequate. This is getting too large.

[RalfJung]

So, removing the WIP then?

[RalfJung]

Looking good aside from the nits.

[pvdrz]

Great, I'm baking another fix in the oven. Let me finish that one and I'll do this one next

[pvdrz]

I ran rustfmt by mistake, but its the last commit D: sorry

[RalfJung]

I ran rustfmt by mistake, but its the last commit D: sorry

Won't this cause conflicts with all your other PRs? (And make reviewing painful.)

[RalfJung]

Oh, the last commit is rustfmt plus other stuff. Please fix that.

[pvdrz]

Ok, we are good to go.

[RalfJung]

Thanks! @bors r+

if you want to make PR with only rustfmt changes, I'd be up for that as well. But beware of conflicts.

[bors]

📌 Commit 003b257 has been approved by RalfJung

[bors]

⌛ Testing commit 003b257 with merge 6a2776e...

[bors]

☀️ Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing 6a2776e to master...