Fix msrv CI: Check for --all-features#890
Merged
thomcc merged 8 commits intorust-lang:mainfrom Nov 4, 2023
NobodyXu:msrv
Merged
Fix msrv CI: Check for --all-features#890thomcc merged 8 commits intorust-lang:mainfrom NobodyXu:msrv
--all-features#890thomcc merged 8 commits intorust-lang:mainfrom
NobodyXu:msrv
Conversation
To make sure that enabling `parallel` feature would not require bumping msrv. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Since most of the time is spent on installing Rust, there's no point in parallelizing it. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
NobodyXu
changed the title
--all-features and macos--all-features
Contributor
Author
|
@thomcc Pinging since I'd like this PR to merge first. It would also make sure that there's no new regression related to MSRV. |
Contributor
Not that my opinion matters, I'm just a user, but I would like to speak up against bumping MSRV if it goes above 1.56 [which matches 2021 edition]. |
Contributor
Author
|
@dot-asm I planned to bump it to 1.53 #889 (comment) so it should be ok for you. It's almost 2.5 years old |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make sure that enabling
parallelfeature would not require bumping msrv.