Use recommended message style in example#4671
Open
stfn2xu wants to merge 1 commit intorust-lang:mainfrom
Open
Conversation
The first example in ch03-02 had a message in the `expect` call written contrary to style recommendations in https://doc.rust-lang.org/stable/std/error/index.html#common-message-styles The example was not *wrong*, just missing an opportunity to reinforce style norms for beginners.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first example in ch03-02 had a message in the
expectcall written contrary to style recommendations inhttps://doc.rust-lang.org/stable/std/error/index.html#common-message-styles
The example was not wrong, just missing an opportunity to reinforce style norms for beginners.