Implement deserialize_any#95
Open
liarokapisv wants to merge 1 commit into
Open
Conversation
eldruin
reviewed
Nov 18, 2025
eldruin
left a comment
Member
There was a problem hiding this comment.
Sounds interesting to me, thank you.
Could you add tests for the other types like string, map, etc?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
deserialize_anywhich is useful when trying to work around the lack ofuntaggedenum support.Mostly follows
serde-json's approach without the inlining.There is definitely room for improvement when it comes to the implementation:
from_strimplementations when parsing for numbers.This will probably require some cleanup, it currently uses a Visitor adaptor to take advantage of the existing
deserialize_fromstrmacro.