Implement defmt::Format and Default for EscapedStr#101
Merged
eldruin merged 2 commits intoNov 18, 2025
Conversation
de-vri-es
changed the title
defmt::Format and Default for EscapedStrdefmt::Format and Default for EscapedStr
de-vri-es
force-pushed
the
defmt-escaped-str
branch
from
7aa6817 to
6b2f594
Compare
eldruin
reviewed
Nov 18, 2025
eldruin
left a comment
eldruin
left a comment
Member
There was a problem hiding this comment.
Sounds good to me! Could you rebase this?
Open
de-vri-es
force-pushed
the
defmt-escaped-str
branch
from
81493ec to
a8cb9e9
Compare
Contributor
Author
|
Rebased! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removes a period from the
Displayimpl ofStringUnescapeError, since periods in error messages makes it very difficult to compose nice log messages with it./edit: See #102 for a fix for CI.