fix!(types): ListUnspentItem's amount should be Amount #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
approved these changes
Jan 1, 2026
Member
|
Thanks man. Can you squash the two commits together please. We use nightly to format because we use the same config file as |
tcharding
reviewed
Jan 1, 2026
| /// The script key. | ||
| pub script_pubkey: ScriptBuf, | ||
| /// The transaction amount. | ||
| #[serde(default, with = "bitcoin::amount::serde::as_btc")] |
Member
There was a problem hiding this comment.
This change is correct but unrelated to the PR. Took me a minute to work out why it was being removed.
Take pity on us poor reviewers please, throw changes like this in a separate patch that says what it does and save me a few clock cycles. This old brain is hard to kick into gear sometimes.
Contributor
Author
There was a problem hiding this comment.
What do you mean unrelated?
I've seen that all bitcoin::Amounts in other parts of the codebase do not need a #[serde(default, with = "bitcoin::amount::serde::as_btc")].
Everything squashed to a single commit in 9541cad
storopoli
force-pushed
the
fix/signed-amount-listunspent
branch
from
0a7b058 to
9541cad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #436