Fix kore_block_dump#1218
Merged
Merged
Conversation
7b3f1ca to
6379075
Compare
30 tasks
gtrepta
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation called
std::strlenon thedatafield of thestring *returned byprint_configuration_to_string, then used that length to allocate and copy the result. However, the runtimestringtype is not null terminated,strlentherefore reads past the end of the buffer.This is fixed by calling
len()on thestring *to obtain the correct length, and replacingstrncpywithmemcpyto copy exactly that many bytes.