-
Notifications
You must be signed in to change notification settings - Fork 0
Create main.md #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yuji91
wants to merge
1
commit into
master
Choose a base branch
from
add_main
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # 概要 | ||
|
|
||
| 基礎編の確認テストとなります。 | ||
| 新しく作業用のブランチを作成し、以下機能の追加実装をお願いします。 | ||
| - ユーザー新規登録機能 | ||
| - ユーザーログイン機能 | ||
| - ユーザーログアウト機能 | ||
| - 投稿編集・削除機能の制限 | ||
|
|
||
| 実装では課題と同様`sorcery`のgemを使用して、各機能ごとに以下の観点を満たすように実装してください。 | ||
| ``` | ||
| 確認観点1:ユーザー新規登録 | ||
| 1-1:ユーザーの新規登録ができる | ||
| 1-2:同じメールアドレスのユーザーは新規登録できない | ||
| 1-3:入力項目が不足している場合に新規登録ができない | ||
|
|
||
| 確認観点2:ユーザーログイン | ||
| 2-1:ユーザーのログインができる | ||
| 2-2:入力項目が不足している場合にログインができない | ||
| 2-3:存在しないユーザーでログインができない | ||
| 2-4:パスワードが間違っている場合にログインができない | ||
|
|
||
| 確認観点3:ユーザーログアウト | ||
| 3-1:ユーザーのログアウトができる | ||
| 3-2:ログインしていない場合、ユーザーのログアウトリンクが表示されない | ||
|
|
||
| 確認観点4:投稿機能 | ||
|
|
||
| 4-1:自分の投稿を編集することができる | ||
| 4-2:自分の投稿を削除することができる | ||
| 4-3:他人の投稿に編集リンクが表示されない | ||
| 4-4:他人の投稿に削除リンクが表示されない | ||
| ``` | ||
|
|
||
| 自動レビューで上記の観点に対応したテストが成功すれば、課題クリアとなります。 | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
細かい文言ですが、「観点」より「ポイント」の方がいいかも
下の方も同じく「確認観点」→「確認ポイント」
判断はいとうさんに任せます:pray:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
「確認観点」はテストコードのitの文章に対応した名前なので、そっちも直さないといけなくなっちゃうんですよね、、
最初の「観点」だけ「ポイント」に変えておこうと思います!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
あ、でも「確認観点」が変わらないのであれば「ポイント」に変えなくてもいい気がしてきました。