Merged
Conversation
src/lib/buildgraphparser.ts
Outdated
| // unreal-build-graph-parser.ts | ||
| // A Deno TypeScript script to read and parse Unreal Engine Build Graph XML files | ||
|
|
||
| import { DOMParser } from "https://deno.land/x/deno_dom/deno-dom-wasm.ts"; |
Contributor
There was a problem hiding this comment.
We cannot do direct https import and support some of the different CLI build targets. Should be able to do import { DOMParser, Element } from "jsr:@b-fuze/deno-dom" .
Note if we want to use the wasm version I believe we need to update our package target to include -wasm flag.
Contributor
Author
There was a problem hiding this comment.
I have removed that file and the associated testing I was doing with it from this branch.
77fb50f to
d39f7eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.