Open
Conversation
jhcipar
approved these changes
Mar 25, 2026
deanq
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the deprecated @remote() decorator by rejecting unknown keyword arguments (preventing silent typo bugs that lead to missing dependencies at runtime), and removes the now-dead extra plumbing from the stub/remote-class execution chain.
Changes:
- Add unknown-kwarg validation for
remote()with “Did you mean …?” suggestions. - Remove the
extraparameter fromcreate_remote_class()andstub_resource()call chains. - Add/adjust unit tests to assert unknown kwargs now raise
TypeError.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/runpod_flash/client.py |
Adds _reject_unknown_kwargs() and enforces kwarg validation in remote(); removes forwarding of extra to stubs/classes. |
src/runpod_flash/execute_class.py |
Removes extra from create_remote_class() signature and stops passing it into stub_resource(). |
src/runpod_flash/stubs/registry.py |
Removes **extra from stub_resource() and registered stub factories; stops using extra.get("sync", ...). |
tests/unit/test_remote_unknown_kwargs.py |
New unit tests covering unknown kwarg rejection + suggestions. |
tests/unit/test_p2_gaps.py |
Updates regression coverage to expect TypeError for unknown kwargs. |
tests/unit/test_stub_registry.py |
Updates stub registry tests to align with new stub_resource() signature. |
tests/unit/test_execute_class.py |
Updates class-execution tests for the updated create_remote_class() signature. |
tests/unit/test_class_caching.py |
Updates cache-related tests for the updated create_remote_class() signature. |
tests/unit/test_regressions.py |
Updates regression tests for the updated create_remote_class() signature. |
tests/unit/test_p1_gaps.py |
Updates gap tests for the updated create_remote_class() signature. |
tests/unit/test_p2_remaining_gaps.py |
Removes extra={} usage in remaining gaps tests. |
tests/integration/test_class_execution_integration.py |
Updates integration tests for the updated create_remote_class() signature and removes timeout kwarg usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
**extra in @Remote silently swallowed misspelled parameters like depndencies=["torch"], causing missing deps at runtime with opaque import errors. Now raises TypeError with "did you mean?" suggestions using difflib.get_close_matches. Also removes dead extra parameter from stub_resource chain and create_remote_class since no downstream consumer used it.
…-2313)
Remove dead **extra parameter from the full chain: client.py remote(),
stubs/registry.py stub_resource() and all registered implementations,
and execute_class.py create_remote_class/RemoteClassWrapper.
Update all test files to remove trailing extra/{} arguments.
- Derive _REMOTE_KNOWN_KWARGS from inspect.signature(remote) so it stays in sync automatically when parameters are added/removed - Move validation after docstring so remote.__doc__ is preserved - Add comment explaining why **extra is retained in the signature
deanq
force-pushed
the
fix/AE-2313-remote-extra-swallows-typos
branch
from
6f92320 to
b7ec056
Compare
Pass sorted(known) to difflib.get_close_matches so "did you mean?" hints are deterministic regardless of set iteration order.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
**extrain@remote()silently swallowed typos likedepndencies=["torch"], causing missing dependencies at runtime with opaque import errors_reject_unknown_kwargs()validation that raisesTypeErrorwith "did you mean?" suggestions usingdifflib.get_close_matchesextraparameter from the full chain:stub_resource(), all 8 registered stub implementations,create_remote_class(), andRemoteClassWrapperTest plan
test_remote_unknown_kwargs.pycovering: single unknown kwarg, typo suggestions for each known param, multiple unknowns, no-suggestion for unrelated names, valid kwargs still acceptedtest_p2_gaps.pyto verify unknown kwargs now raiseTypeError(previously tested they were silently accepted)make quality-checkpasses (format, lint, tests, coverage)Closes AE-2313