fix: AE-2316: field validator for serverless idleTimeout#287
Open
fix: AE-2316: field validator for serverless idleTimeout#287
Conversation
jhcipar
changed the title
|
📝 Documentation updates detected! New suggestion: Document valid range for idle_timeout parameter Tip: Filter the Dashboard by labels or assignees to focus on what matters to you 🔎 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds construction-time validation for the idleTimeout field on serverless endpoints to match backend constraints (1–3600 seconds), preventing invalid configs from failing later at deploy time.
Changes:
- Add a Pydantic
field_validatorforidleTimeoutinServerlessResource. - Add unit tests covering invalid and boundary-valid
idleTimeoutvalues forServerlessResource. - Add a unit test confirming
LiveServerlessrejects an invalididleTimeout.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/runpod_flash/core/resources/serverless.py |
Enforces idleTimeout range (1–3600) during model construction via field_validator. |
tests/unit/resources/test_serverless.py |
Adds parametrized tests for invalid values and valid boundary values. |
tests/unit/resources/test_live_serverless.py |
Adds a regression test ensuring LiveServerless inherits/enforces the idleTimeout validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a field validator to
idleTimeoutso errors happen at construction time rather than deploy time; backend currently restrictsidleTimeoutto between 1 and 3600s.