fix: add grace period to allow registry to start up #282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: During testing for macOS keychain integration with Finch, container tests failed to login to the test registry set up in common tests. These failed both locally and on CI. I noticed that, unlike similar registry container setup in Finch VM E2E tests, this setup did not have any grace period to allow the registry to become accessible. Upon adding 20 seconds of wait time, tests pass locally. To add the wait, I follow the pattern in Finch E2E tests.
Testing done: Prior to adding a grace period, we see this error in Finch locally (with the same failures in CI):
with a common error pattern:
Upon adding some wait time, we see the following locally:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.