Handle null values for ansible_distribution and ansible_os_name#323
Closed
sculliga wants to merge 1 commit intorundeck-plugins:mainfrom
Closed
Handle null values for ansible_distribution and ansible_os_name#323sculliga wants to merge 1 commit intorundeck-plugins:mainfrom
sculliga wants to merge 1 commit intorundeck-plugins:mainfrom
Conversation
Contributor
|
Sorry we missed you on this. We're trying to be better, but since so much time has passed we're going to close this for now. If you still need the improvement please provide a new PR or open an Issue and we will look into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ansible made changes to their Windows setup module that sets these facts to
nullif the account connecting to a Windows node does not have administrative rights. The Rundeck Ansible plugin is not handling thesenullvalues properly.Ansible Changes: Here
The issue I submitted to Ansible where they explained the expected behavior: Here
This PR should fix #311