Skip to content

Sawra/sdk go fix#102

Merged
sawradip merged 2 commits into
mainfrom
sawra/sdk_go_fix
Nov 19, 2025
Merged

Sawra/sdk go fix#102
sawradip merged 2 commits into
mainfrom
sawra/sdk_go_fix

Conversation

@sawradip
Copy link
Copy Markdown
Contributor

@sawradip sawradip commented Nov 19, 2025

Summary by CodeRabbit

  • Chores
    • Reorganized Go SDK module structure for simplified installation and imports. Updated module path from nested repository structure to root-level, streamlining the installation command and import paths for cleaner developer experience.
    • Improved release workflow to automatically extract and include changelog content in GitHub releases instead of generic notes.

- Removed unnecessary whitespace in the serializer tests for improved readability and consistency.
- Adjusted the release script to handle existing tags and changelog generation more effectively.
- Separated changelog updates into distinct commits for clarity.
- Introduced a new Go SDK with comprehensive client functionality, error handling, and streaming capabilities.
- Updated documentation and examples to reflect changes in SDK usage and installation.
- Enhanced configuration management and database interactions for local agent management.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Nov 19, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The PR restructures the runagent-go module from a nested path to root-level with internal package reorganization, updates all associated import paths, modifies the release workflow to extract and inject changelog content dynamically, and reorders tag creation timing in the release script to occur before changelog generation.

Changes

Cohort / File(s) Summary
Release Workflow and Scripts
.github/workflows/create-release.yml, release.sh
Added "Extract changelog for version" step to compute and output changelog excerpts; updated release body to inject extracted changelog instead of static text; moved tag creation prior to changelog generation; reordered and separated commit/changelog handling steps; set generate_release_notes to false.
runagent-go Module Path Updates
runagent-go/go.mod, runagent-go/README.md, runagent-go/PUBLISH.md
Changed module path from github.com/runagent-dev/runagent/runagent-go to github.com/runagent-dev/runagent-go; updated installation commands, import examples, and verification steps; altered release tag format from sdk-go-vX.Y.Z to vX.Y.Z; adjusted build/test and file staging commands to operate from repository root.
runagent-go Internal Import Path Updates
runagent-go/client.go, runagent-go/examples/basic.go, runagent-go/examples/streaming.go, runagent-go/internal/client/client.go, runagent-go/internal/config/config.go, runagent-go/internal/db/db.go, runagent-go/internal/server/server.go, runagent-go/internal/utils/port.go
Updated import paths from nested runagent/pkg/* to internal equivalents (e.g., runagent-go/internal/constants, runagent-go/internal/db); no logic or behavioral changes.
Formatting
runagent-rust/runagent/src/utils/serializer.rs
Adjusted blank line spacing around test assertions; no functional changes.

Sequence Diagram(s)

sequenceDiagram
    participant Release as Release Script
    participant Git as Git
    participant GhCliff as git-cliff
    participant GhAction as GitHub Action
    participant GhAPI as GitHub API

    Note over Release: OLD FLOW
    Release->>GhCliff: Generate changelog (no tag yet)
    GhCliff-->>Release: Changelog
    Release->>Git: Commit changes
    Release->>Git: Create tag
    
    Note over Release: NEW FLOW
    Release->>Git: Handle existing tag
    Release->>Git: Create tag (before changelog)
    Release->>GhCliff: Generate changelog (tag exists)
    GhCliff-->>Release: Changelog with tag reference
    Release->>Git: Commit version changes
    Release->>Git: Commit CHANGELOG.md separately
    Release->>GhAction: Pass to GitHub Action
    GhAction->>GhAction: Extract changelog for version
    GhAction-->>GhAPI: Create release with extracted changelog
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

  • Specific areas requiring attention:
    • release.sh: Tag creation timing and changelog generation order—verify git-cliff can properly reference the newly created tag and that the two-step commit strategy (version + changelog) is correct
    • .github/workflows/create-release.yml: Validate the extract_section function correctly parses CHANGELOG.md and handles edge cases (missing sections, malformed entries)
    • runagent-go/go.mod: Confirm module path change doesn't break existing downstream dependencies or require coordinated updates
    • Verify all import path changes in runagent-go are consistent and no stale references to runagent/pkg/* remain

Possibly related PRs

Poem

🐰 A module freed from nested chains,
Lives at root without constraints,
With imports neat and pathways clear,
And changelogs that appear,
The rabbit hops—release flows bright! 🚀

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sawra/sdk_go_fix

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5ec42e6 and 2f88b2e.

📒 Files selected for processing (14)
  • .github/workflows/create-release.yml (2 hunks)
  • release.sh (1 hunks)
  • runagent-go/PUBLISH.md (5 hunks)
  • runagent-go/README.md (2 hunks)
  • runagent-go/client.go (1 hunks)
  • runagent-go/examples/basic.go (1 hunks)
  • runagent-go/examples/streaming.go (1 hunks)
  • runagent-go/go.mod (1 hunks)
  • runagent-go/internal/client/client.go (1 hunks)
  • runagent-go/internal/config/config.go (1 hunks)
  • runagent-go/internal/db/db.go (1 hunks)
  • runagent-go/internal/server/server.go (1 hunks)
  • runagent-go/internal/utils/port.go (1 hunks)
  • runagent-rust/runagent/src/utils/serializer.rs (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sawradip sawradip merged commit ccbe61e into main Nov 19, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant