fix(milliquas): disable colour K-correction that clamped quasars to blue#282
Merged
Conversation
The colour-index K-correction subtracts kPerZ·z in ramp-position units, where the whole blue→white→red ramp spans only 2.0. Milliquas redshifts run z ≈ 1–7, so kPerZ=0.5 subtracted 0.5–3.5 ramp units — more than the observed B−R colour of nearly every quasar — pinning the entire catalog to the t=0 blue floor regardless of its real colour. Set kPerZ=0 so observed B−R maps straight to the ramp and the genuine blue→red AGN spread survives. A redshift-aware quasar correction belongs in a dedicated bias-correction subsystem with its own QLF, not here. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rulkens
added a commit
that referenced
this pull request
Jun 7, 2026
…ow-up (#283) The clamp half shipped in #282 (kPerZ=0). What remains is the deeper semantic mismatch — quasars reuse the galaxy star-forming↔elliptical ramp where "blue" carries the wrong meaning. Capture the three encoding directions (AGN ramp / redshift / class byte) for a future brainstorm. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every Milliquas quasar rendered as the same pure blue (read by the galaxy colormap as "blue star-forming").
Root cause
pickColourIndexapplies a redshift K-correctionrestCI = observedCI − kPerZ·z, clamped to[0, 2], where the blue→white→red ramp spans only2.0. Milliquas'scolourSpecusedkPerZ: 0.5, and quasar redshifts run z ≈ 1–7, so the correction subtracted 0.5–3.5 ramp units — more than the observed B−R colour of nearly every quasar. The result clamped the whole catalog to thet=0blue floor regardless of its real colour.Empirical check against
pickColourIndex(same colour, varying z):The same galaxy collapses from t=0.82 to t=0.00 purely by moving it to higher z.
kPerZ=0.5was tuned for low-z galaxy surveys (z≲0.1, negligible correction); applied to a quasar catalog it becomes the dominant term.Fix
Set
kPerZ: 0for Milliquas so observed B−R maps straight to the ramp and the genuine blue→red AGN spread survives. A redshift-aware quasar correction belongs in a dedicated bias-correction subsystem with its own QLF, not bolted onto the galaxy ramp.Note: the catalog still skews blue after this change — quasars genuinely are blue. A follow-up will look at giving AGN their own colormap rather than reusing the galaxy star-forming↔elliptical ramp (the deeper semantic mismatch).
Verification
npm run typecheckcleancolourIndex+buildPointInterleavedBuffertests pass (17).binrebuild / R2 re-sync needed.🤖 Generated with Claude Code