Info card tweaks: morphology types, unified catalogues row, leaner layout#281
Merged
Conversation
Tweaks across the galaxy/POI info cards (desktop + mobile):
- Famous galaxies show their curated Hubble type ("Barred spiral (SBb)")
instead of "Unknown galaxy type". New pure formatMorphology() util; the
builder exposes it as its own GalaxyInfo.morphology field (independent of
the colour-derived galaxyType), and the cards render
`morphology ?? galaxyType.description`.
- One "Catalogues" row for every galaxy, rendered under the thumbnail. The
builder now emits GalaxyInfo.catalogues ({label, href}[]) with the label
chosen where each URL is built, so it can't drift from the page it points
at. Removes the duplicate famous-NED / bottom-"View on NED" mechanisms and
the card's source branch (card is pure presentation).
- Source badge (Famous/SDSS/2MRS/GLADE/category) folded onto the name row
across all four cards.
- "Lean hero" fold: only Redshift z + Diameter sit above "More details";
RA/Dec/apparent-mag move below.
- Fix the SDSS object link: the Quick Look (quickobj) endpoint 500s for some
objIds; switch to the canonical Explore Summary page.
Moves famousWikipediaTitle to utils/format so the service layer no longer
imports from components/. Typecheck clean; 2443 tests pass.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
skymap | 7d0c8ed | Commit Preview URL Branch Preview URL |
Jun 07 2026, 09:29 PM |
Captures the brainstormed Option A (scroll-snap bottom sheet, minimal peek, drag gesture) for the selected-target card on mobile. Panel launcher is a gated fast-follow pending an entanglement-radar pass over SettingsPanel. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Renames the structure-card family from the legacy 'poi' naming to 'structure', matching the StructureRecord data type it already consumes: PoiDetailCard -> StructureDetailCard, CompactPoiCard -> CompactStructureCard, and the poi prop/vars -> structure throughout InfoCard. The card eyebrow now reads 'Structure' instead of 'POI'. Engine-wide identifiers (isPoi, POI_CATEGORY_INFO, the #poi= deep-link param) are intentionally left as a separate, larger migration. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Track the poi* -> structure* convergence as a high-priority surfaced issue: enumerate the engine/identity/URL holdouts, flag the #poi= deep-link param as a persisted format needing back-compat, and prescribe entanglement-radar (map) + /simplify (apply). Also note the mobile bottom-sheet spec under the existing reflow item. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The explore/summary endpoint also 500s; quickobj is the lighter object page the link is meant to open. The earlier JsonSerializationException was SkyServer's scheduled-maintenance outage, not a quickobj defect. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tweaks across the galaxy/POI info cards (desktop + mobile). First commit on a branch we'll keep adding to.
Changes
formatMorphology()util ("SBb"→"Barred spiral (SBb)","E"→"Elliptical (E)", …). Exposed as its ownGalaxyInfo.morphologyfield, independent of the colour-derivedgalaxyType; cards rendermorphology ?? galaxyType.description.GalaxyInfo.catalogues: {label, href}[], with the label chosen at the point each URL is built so it can't drift from the page it points at. Removes the old duplicate famous-NED / bottom-"View on NED" mechanisms and the card'ssourcebranch.quickobj) endpoint returns a server error for some objIds; switched to the canonical Explore Summary page.Decomplection (entanglement-radar)
morphologyis its own field, not overloaded ontogalaxyType.description.'Unknown galaxy type'literal.famousWikipediaTitletoutils/formatso the service layer no longer imports fromcomponents/.Verification
npm run typecheckclean🤖 Generated with Claude Code