avm2: Various fixes and improvements to loading constant pool entries#23113
Merged
Lord-McSweeney merged 11 commits intoruffle-rs:masterfrom Feb 28, 2026
Merged
avm2: Various fixes and improvements to loading constant pool entries#23113Lord-McSweeney merged 11 commits intoruffle-rs:masterfrom
Lord-McSweeney merged 11 commits intoruffle-rs:masterfrom
Conversation
Lord-McSweeney
added
A-avm2
SuchAFuriousDeath
approved these changes
Feb 24, 2026
kjarosh
reviewed
Feb 24, 2026
Collaborator
Is the goal to eventually get rid of it completely? |
Lord-McSweeney
force-pushed
the
avm2-pool-fixes
branch
from
09435c5 to
8cc4c05
Compare
SuchAFuriousDeath
approved these changes
Feb 26, 2026
Lord-McSweeney
force-pushed
the
avm2-pool-fixes
branch
from
8cc4c05 to
e95bc20
Compare
These were doing nothing but adding indirection
- Add a test for AVM2 method specifying a zero constant-pool index for the default value of an optional parameter - Add a test for `pushint`, `pushuint`, and `pushdouble` ops specifying zero and invalid indices for their index
This correctly throws an error when the metadata name is index zero
…pool index is out of bounds
This adds `make_error_1060`
…messages This makes the messages match FP
Lord-McSweeney
force-pushed
the
avm2-pool-fixes
branch
from
e95bc20 to
ab27985
Compare
Hancock33
added a commit
to Hancock33/batocera.piboy
that referenced
this pull request
Mar 1, 2026
------------------------------------------------------------------------------------------ duckstation.mk fba9913b3ea2ad995253e1a5d571f200c2ff0b39 # Version: Commits on Mar 01, 2026 ------------------------------------------------------------------------------------------ Qt: Tidy up mouse controller view Image was way too large., ----------------------------------------------------------------------------------- eden.mk 2991bd18ef18d46069344e816591e34f05dff397 # Version: Commits on Mar 01, 2026 ----------------------------------------------------------------------------------- [vk] Enable VK_IMG_filter_cubic on powervr (#3643) ------------------------------------------------------------------------------------ rpcs3.mk 5ca19eabd548d517b8834e2aa3e08ab90e8d9ebf # Version: Commits on Feb 28, 2026 ------------------------------------------------------------------------------------ NP code review sceNpTrophy fixes - sceNpTrophyGetTrophyUnlockState: signed 1 was potentially shifted by 31(UB) - sceNpTrophyUnlockTrophy: used a reader_lock and was missing check for read only context cellGame fixes - cellHddGameCheck: missing log parameters - cellGameDataCheckCreate2: missing log parameter - cellGameThemeInstall: condition inverted checking for extension + added tolower just in case - cellGameThemeInstallFromBuffer: OOB access, buf is always filled from the start and then used as a parameter to the CB sceNp fixes - sceNpManagerGetTicket: Made accurate from RE - sceNpDrmGetTimelimit: Fix msec calculation sceNp2 fixes -sceNpMatching2ContextStartAsync: avoid capturing ctx -sceNpMatching2ContextStop: Minor error value swap rpcn_client fixes -add_friend: missing log parameter -handle_friend_notification: misc validation issue np_handler fixes -ticket: Missing move in move constructor -ticket::parse: Misc validation fix -get_player_history_entry: potential UB fix np_requests fixes -Wrong CB event_type set for get_room_member_data_external_list! -reply_tus_get_data was not copying status data! -Order of error check in reply_get_room_member_data_external_list was wrong -Improved logging np_requests_gui: -Added missing guards for gui_notifications upnp_handler fixes -Highest density of bugs per line of code in the west, let's pretend I never wrote this signaling_handler fixes -Swapped to multimap to avoid collisions on timestamps Misc fixes, -------------------------------------------------------------------------------------------- supermodel-es.mk 155e4cbb944d3c04268fe5910bc836cfc249b6a6 # Version: Commits on Feb 28, 2026 -------------------------------------------------------------------------------------------- 0.3a-d6dec3d, ------------------------------------------------- vice.mk r46003 # Version: Commits on Feb 28, 2026 ------------------------------------------------- null ------------------------------------------------------------------------------------- vita3k.mk c4a097bfec8675cb2e646bd4791d7b2cd5747cc6 # Version: Commits on Mar 01, 2026 ------------------------------------------------------------------------------------- build(deps): bump the ci-deps group with 2 updates Bumps the ci-deps group with 2 updates: [actions/upload-artifact](https://github.com/actions/upload-artifact) and [actions/download-artifact](https://github.com/actions/download-artifact). Updates `actions/upload-artifact` from 6 to 7 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v6...v7) Updates `actions/download-artifact` from 7 to 8 - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v7...v8) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major dependency-group: ci-deps - dependency-name: actions/download-artifact dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major dependency-group: ci-deps ... Signed-off-by: dependabot[bot] <support@github.com>, ------------------------------------------------------------------------------------------- xenia-canary.mk 48111e8fbadfbcaa1d43b09216a7a4c8581bea99 # Version: Commits on Mar 01, 2026 ------------------------------------------------------------------------------------------- [D3D12] Fix device lost with resolution scaling in 3D-as-2D textures, ------------------------------------------------------------------------------------------- xenia-native.mk 48111e8fbadfbcaa1d43b09216a7a4c8581bea99 # Version: Commits on Mar 01, 2026 ------------------------------------------------------------------------------------------- [D3D12] Fix device lost with resolution scaling in 3D-as-2D textures, --------------------------------------------------------------- ruffle.mk nightly-2026-03-01 # Version: Commits on Mar 01, 2026 --------------------------------------------------------------- ## What's Changed * avm2: Various fixes and improvements to loading constant pool entries by @Lord-McSweeney in ruffle-rs/ruffle#23113 * core: Implement FloatDuration type by @SuchAFuriousDeath in ruffle-rs/ruffle#23077 * tests: Do not save expected image when it doesn't exist by @kjarosh in ruffle-rs/ruffle#23061 * desktop: Add disable-library-validation to macOS entitlements to fix libopenh264 not loading by @ChrisCPI in ruffle-rs/ruffle#23146 * avm2: In SWFv10 and above, frame-script-queued gotos can run o-op goto\ logic by @Lord-McSweeney in ruffle-rs/ruffle#23032 * avm2: Propagate AGAL errors to ActionScript by @SuchAFuriousDeath in ruffle-rs/ruffle#23122 * audio: Add G.711 decoder by @SuchAFuriousDeath in ruffle-rs/ruffle#22921 * chore: Update translations from Crowdin by @kjarosh in ruffle-rs/ruffle#23149 ## New Contributors * @ChrisCPI made their first contribution in ruffle-rs/ruffle#23146 **Full Changelog**: ruffle-rs/ruffle@nightly-2026-02-28...nightly-2026-03-01, ------------------------------------------------------------------------------------ box64.mk dbfafb82fae4e556a3bede88610a966de72c421e # Version: Commits on Mar 01, 2026 ------------------------------------------------------------------------------------ [BOX32] Add libSDL2-2.0.so.1 to 32-bit library list (#3595) The 64-bit library_list.h already maps libSDL2-2.0.so.1 to the sdl2 wrapper, but library_list_32.h only had libSDL2-2.0.so.0. This caused 32-bit games shipping SDL2 with soname .so.1 (e.g. Grim Fandango Remastered) to fall through to full emulation instead of using the native SDL2 wrapper., --------------------------------------------------------------------------------------- corsixth.mk 6108b6ffa762795d91c0f3c9b0676b29f28da7ff # Version: Commits on Mar 01, 2026 --------------------------------------------------------------------------------------- Merge pull request #3253 from TheCycoONE/cleanup_list_bottom Refactor: remove list_bottom, --------------------------------------------------------------------------------------- etlegacy.mk 49097136cd7b8f99e638d618294933cbc421f3ad # Version: Commits on Mar 01, 2026 --------------------------------------------------------------------------------------- game: remove newline from surrender vote msg (#3355) G_LogExit already appends it, resulting in two newlines in the log., ------------------------------------------------------------------------------------------ fallout2-ce.mk e8d85dbdd8320c4a37f93c1124d13c4826dcb6bf # Version: Commits on Mar 01, 2026 ------------------------------------------------------------------------------------------ Revert to original behaviour in window.cc window existence checks (#291) revert to original behaviour in window.cc window existence checks * flagging probably mistaken function, --------------------------------------------------------------------------------------- openjazz.mk 4079a331ad5aa06a5624e5e2b9c38d7432391137 # Version: Commits on Mar 01, 2026 --------------------------------------------------------------------------------------- Prepare 20260301 release, ------------------------------------------------------------------------------------------------- shadps4-qtlauncher.mk 135727a56aceef55f7038f1197f862a394a05196 # Version: Commits on Mar 01, 2026 ------------------------------------------------------------------------------------------------- [ci skip] Qt GUI: Update Translation. (#258) Co-authored-by: georgemoralis <4313123+georgemoralis@users.noreply.github.com>, -------------------------------------------------------------------------------------- xpadneo.mk 5d7942d78d490210fbe85a7f2f234fee329a0fd4 # Version: Commits on Mar 01, 2026 -------------------------------------------------------------------------------------- xpadneo, core: Remove unused headers Signed-off-by: Kai Krakow <kai@kaishome.de>, ---------------------------------------------------------------------------------------- retroarch.mk 8b5319240546af2a9ded174f9815a800864a1171 # Version: Commits on Mar 01, 2026 ---------------------------------------------------------------------------------------- Fetch translations from Crowdin, -------------------------------------------------------------------------------------------- vpinball-next.mk fa32070afeb174e0f009c954a7dc2bd4220fb315 # Version: Commits on Mar 01, 2026 -------------------------------------------------------------------------------------------- InGameUI: move remaining ball rendering options, ---------------------------------------------------------------------------------------- doomretro.mk 5d8e3080785f748de649997e46d759324d373cc0 # Version: Commits on Mar 01, 2026 ---------------------------------------------------------------------------------------- Update doomretro.desktop, -------------------------------------------------------------------------------------- vkquake.mk 5dfca693cd1ad5c9095ec8ae17b8c1c3f856be33 # Version: Commits on Feb 27, 2026 -------------------------------------------------------------------------------------- SV_Phys : Add guard against calling SV_Impact on freed edicts (#878), -------------------------------------------------------------------------------------- yquake2.mk 79344b735abe7b60ffbdf4ae0e2132449091f143 # Version: Commits on Feb 28, 2026 -------------------------------------------------------------------------------------- fix build 1324195a, -------------------------------------------------------------------------------------------------- libretro-clownmdemu.mk c19addc2aa876df66516b3bb83b4fd93f90b46a9 # Version: Commits on Feb 28, 2026 -------------------------------------------------------------------------------------------------- Update common (now with 4-player support)., ------------------------------------------------------------------------------------------------------ libretro-doublecherrygb.mk c502205ef34dbe6b484348b1f4ccbc68dd451a55 # Version: Commits on Mar 01, 2026 ------------------------------------------------------------------------------------------------------ 🔇 removed some Debug Logs,
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also removes a lot of our remaining uses of
RustError