FFI codeowners-rs #126
Merged
FFI codeowners-rs #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perryqh
force-pushed
the
ph/native-extension
branch
from
c611a49 to
a614bc8
Compare
perryqh
force-pushed
the
ph/native-extension
branch
from
a614bc8 to
e743fad
Compare
perryqh
force-pushed
the
ph/native-extension
branch
from
716b196 to
15dad90
Compare
perryqh
force-pushed
the
ph/native-extension
branch
from
15dad90 to
0ea6b27
Compare
perryqh
force-pushed
the
ph/native-extension
branch
from
d502e94 to
dbc8624
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change doing?
Replaces github CODEOWNERS generation, validation, and per-file ownership ruby implementation with a FFI to codeowners-rs.
This is a breaking change as
extensionswill no longer be supported.Why?
The pure ruby implementation is very slow against a large repo
Ruby -> Rust
Benchmark 1: direct codeowners-rs
Benchmark 2: code_ownership gem -> codeowners-rs (this PR). Less than 1/2 second slower than pure rust!
Ruby only - code_ownership v1.39.0
Benchmark 1: code_ownership v1.39.0