fix: enforce conventional commit format on PR titles#909
fix: enforce conventional commit format on PR titles#909tmchow wants to merge 2 commits intortk-ai:developfrom
Conversation
Add a GitHub Actions workflow that validates PR titles against the conventional commit format before merge. Uses amannn/action-semantic-pull-request to check titles match: feat|fix|chore|docs|ci|refactor|perf|test|build|style This prevents release-please failures caused by non-conventional merge commit titles (the root cause of the v0.31.0 -> v0.33.0 release gap). Fixes rtk-ai#805 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Hello, thanks for the contribution, For types you have added many tags that are not supported since for now we just want to use fix/feat/chore , refering to CONTRIBUTING.md. Since PR can group multiples features/fixtures type, we for now keep versioning level tag like those. |
|
Also quick thoughts but you're using an external git action, since you want to check PR title naming convention, and it is pretty simple, we could just script it instead of using a dependencies. Did you identify any other interesting use or future usage that we could get from this dependencies? I'm looking at this PR because it could fit in the contributor onboarding refacto we are working on |
Replace external amannn/action-semantic-pull-request action with an inline bash regex check. Reduce allowed types to fix/feat/chore per CONTRIBUTING.md.
|
Addressed in b39f45c: replaced the external action with an inline bash Good call on avoiding the dependency — the regex is simple enough that a script handles it fine. |
Just to clarify, was issue #805 not worth fixing then? Was just trying to tackle something to help :) happy to close if that's the case, just lmk |
Summary
.github/workflows/pr-title-check.ymlusingamannn/action-semantic-pull-request@v5Test plan
Fixes #805
This contribution was developed with AI assistance (Claude Code).