Skip to content

fix: enforce conventional commit format on PR titles#909

Open
tmchow wants to merge 2 commits intortk-ai:developfrom
tmchow:osc/805-ci-conventional-commits
Open

fix: enforce conventional commit format on PR titles#909
tmchow wants to merge 2 commits intortk-ai:developfrom
tmchow:osc/805-ci-conventional-commits

Conversation

@tmchow
Copy link
Copy Markdown

@tmchow tmchow commented Mar 29, 2026

Summary

  • Add .github/workflows/pr-title-check.yml using amannn/action-semantic-pull-request@v5
  • Validates PR titles match conventional commit format on PRs targeting master and develop
  • Allowed types: feat, fix, chore, docs, ci, refactor, perf, test, build, style

Test plan

  • Workflow syntax validated
  • PR title for this PR passes the check (self-validating)

Fixes #805

This contribution was developed with AI assistance (Claude Code).

Add a GitHub Actions workflow that validates PR titles against the
conventional commit format before merge. Uses amannn/action-semantic-pull-request
to check titles match: feat|fix|chore|docs|ci|refactor|perf|test|build|style

This prevents release-please failures caused by non-conventional merge
commit titles (the root cause of the v0.31.0 -> v0.33.0 release gap).

Fixes rtk-ai#805

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@aeppling
Copy link
Copy Markdown
Contributor

Hello, thanks for the contribution,

For types you have added many tags that are not supported since for now we just want to use fix/feat/chore , refering to CONTRIBUTING.md.

Since PR can group multiples features/fixtures type, we for now keep versioning level tag like those.

@aeppling
Copy link
Copy Markdown
Contributor

Also quick thoughts but you're using an external git action, since you want to check PR title naming convention, and it is pretty simple, we could just script it instead of using a dependencies.

Did you identify any other interesting use or future usage that we could get from this dependencies?

I'm looking at this PR because it could fit in the contributor onboarding refacto we are working on

Replace external amannn/action-semantic-pull-request action with an
inline bash regex check. Reduce allowed types to fix/feat/chore per
CONTRIBUTING.md.
@tmchow
Copy link
Copy Markdown
Author

tmchow commented Mar 29, 2026

Addressed in b39f45c: replaced the external action with an inline bash grep -E check and narrowed the allowed types to fix/feat/chore per CONTRIBUTING.md.

Good call on avoiding the dependency — the regex is simple enough that a script handles it fine.

@tmchow
Copy link
Copy Markdown
Author

tmchow commented Mar 30, 2026

Also quick thoughts but you're using an external git action, since you want to check PR title naming convention, and it is pretty simple, we could just script it instead of using a dependencies.

Just to clarify, was issue #805 not worth fixing then? Was just trying to tackle something to help :) happy to close if that's the case, just lmk

@tmchow tmchow changed the title ci: enforce conventional commit format on PR titles fix: enforce conventional commit format on PR titles Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants