Add asynchronous server #1247
Draft
Add asynchronous server #1247
+345
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rthalley
reviewed
Dec 30, 2025
Owner
|
I'm pretty sure I don't want it in the official API, but dnspython already has a more capable nameserver skeleton in tests/nanonameserver.py. Also, if we did export a server framework, then any async code should also support trio. I'm skeptical of the utility of a generic server in the API, as my experience writing servers with dnspython is that the needs of real servers far exceed what any skeleton would provide. Taking something like nanonameserver as a basis for a server is certainly viable, but it's more of a starting point for edits than it is a proper API. |
darkdragon-001
force-pushed
the
async-server
branch
3 times, most recently
from
1489e2c to
a326b46
Compare
Adjust the default values of the DDNS client example to connect to the one from the server example.
darkdragon-001
force-pushed
the
async-server
branch
from
a326b46 to
e653d24
Compare
The previous datagram socket for client use only allowed receiving a single message before it has been read (implementation via future). For server use cases we would like to receive messages continuously. This commit implements a dummy socket embedding received data such that dns.asyncquery.receive_udp() can still be used to read the message in order to keep the interface as close as possible to the TCP implementation. Also implementing a proper server class as public interface.
darkdragon-001
force-pushed
the
async-server
branch
from
e653d24 to
b024635
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it much more convenient to create servers. See diff to #1246 for
examples/ddns_server.py.Based on #1246