Use foldr instead of foldl and reverse in Html.Styled.Internal#331
Open
ahstro wants to merge 1 commit intortfeldman:html-styledfrom
Open
Use foldr instead of foldl and reverse in Html.Styled.Internal#331ahstro wants to merge 1 commit intortfeldman:html-styledfrom
ahstro wants to merge 1 commit intortfeldman:html-styledfrom
Conversation
184bf77 to
1026935
Compare
Owner
|
@ahstro I'm concerned that this would actually cause a regression instead of working as intended 😅 - do you think you could add a test case demonstrating that it still works properly? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using
List.foldlto reduce children and then having toList.reversethe child nodes, useList.foldrand skip reversing.I think this makes sense, since
Dicts (the other thing being accumulated with thefold*) are often stated as a valid to use when order is irrelevant. I suppose there might be some potential problem if the order of theDictis actually relied upon to order the styles properly (them being cascading and all). The example page looks the same after this change, but it's not very complex, so the likelihood of styles conflicting based on order is minimal.