Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code is currently in-progress and should not be merged
This PR will add
@font-facesupport for the most commonly used attributes:font-familysrcfont-variantfont-weightfont-styleIt does not implement
unicode-range,font-feature-settings, orfont-stretch. Other authors are encouraged to add these in later.Questions for elm-css core team
There already exist functions called
fontFamilyandsrcin elm-css. They seem to be incompatible with the semantics of@font-face. To wit:fontFamilytakes onlyFontFamily a, which only allows forserif,sansSerif,monospace,cursiveandfantasy. In this case, we're defining a brand new font with a new name. The docs suggest usingfontFamiliesif you want custom-named fonts, but that doesn't make sense here because we're defining one font name.srcis of typeImportType compatible -> String, and I just really don't know what to do about that.To see what an ideal implementation would look like, see the proposed fixture.