Improve VLAN PCP handling for IPoE control traffic and updates for documentation#376
Merged
GIC-de merged 1 commit intortbrick:devfrom Mar 5, 2026
Merged
Improve VLAN PCP handling for IPoE control traffic and updates for documentation#376GIC-de merged 1 commit intortbrick:devfrom
GIC-de merged 1 commit intortbrick:devfrom
Conversation
…/NS when client type is ipoe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves VLAN PCP handling for IPoE control traffic and updates configuration docs to clarify priority precedence.
What Changed
Code
bbl_tx_encode_packet_arp_requestbbl_tx_encode_packet_arp_replybbl_tx_encode_packet_icmpv6_nseth.vlan_outer_priority = g_ctx->config.ipoe_vlan_priorityeth.vlan_inner_priority = eth.vlan_outer_priorityICMPv6 RSalready usedipoe.vlan-priorityand remains unchanged.Documentation
Updated config docs to reflect actual behavior and precedence:
docsrc/sources/configuration/ipoe.rstipoe.vlan-prioritydescription.ARP,ICMPv6 ND/RS/NS) and default for DHCP/DHCPv6 unless overridden.docsrc/sources/configuration/dhcp.rstdhcp.vlan-priorityoverridesipoe.vlan-priorityfor DHCP packets only.docsrc/sources/configuration/dhcpv6.rstdhcpv6.vlan-priorityoverridesipoe.vlan-priorityfor DHCPv6 packets only.Behavior / Precedence
ipoe.vlan-prioritydhcp.vlan-priority(if configured) overrides defaultdhcpv6.vlan-priority(if configured) overrides defaultipoe.vlan-priorityMotivation
In IPoE mode, ARP and ICMPv6 NS were missing explicit PCP assignment, which caused inconsistent QoS marking versus DHCP/DHCPv6 and stream traffic expectations. This PR makes control-plane PCP behavior deterministic and documented.