Conversation
- implement StaticTokenProvider returning consistent token - introduce WithStaticToken option in client configuration - ensure no calls to /api/v0/auth_extended with retries on 401 - enhance AuthProvider to error on missing credentials
- add tests for SetDefault(nil) using slog.Default - verify emitted slog records with Debug/Info/Warn/Error wrappers - enhance tests in pkg/models for error handling in annotations - ensure proper behavior of DiskImage1 unmarshal and omit optional fields
- add `lint` job in GitHub Actions after build - integrate `go vet` and `golangci-lint-action v6` for linting - update Makefile with phony targets `test`, `vet`, `lint` - revise README.md with new linting instructions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves client authentication, increases test coverage for edge cases,
and adds consistent linting in both CI and local workflows.
Changes:
and WithStaticToken; tighten auth error handling.
behavior; add model tests for annotation union handling and ImageDefinition
disk_image nil/missing/unmarshal behavior.
targets (test/vet/lint); update README linting instructions.
Why: