Open
Conversation
My team has encountered an issue where `goversion` can no longer recognize our builds (see issue rsc#12) due to a symbolic debugging entry for `_runtime.buildVersion`. If we omit such entries from the symbol list before looking for `_runtime.BuildVersion`, then `goversion` works for our builds once again.
FiloSottile
added a commit
to FiloSottile/goversion
that referenced
this pull request
Dec 15, 2020
Imported the cmd/go/internal/version implementation at c32140fa94cfc51a2152855825f57e27ae3ba133, and restored Symbols and TextRange to implement the gccgo and crypto checks. It looks like the amd64 matching had broken, but it should be more stable to just track what we do upstream with minimal modifications, so I replaced the core mechanism rather than fixing the matcher. Fixes rsc#14 Fixes rsc#12 Fixes rsc#11 Fixes rsc#7 Closes rsc#13 Closes rsc#9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My team has encountered an issue where
goversioncan no longerrecognize our builds (see issue #12) due to a symbolic debugging entry
for
_runtime.buildVersion.If we omit such entries from the symbol list before looking for
_runtime.BuildVersion, thengoversionworks for our builds onceagain.