Merged
Conversation
…S. Also run tests under Python 3.13 as well.
Contributor
Author
|
Looks like we're running into issue: https://sourceforge.net/p/docutils/bugs/483/ I'll simply remove the problematic dev-dependency (an install it manually from the workflow) for now so we can have a green CI |
Looks like I'm running into this issue specifically on windows/python3.8: pypa/setuptools#4483
Contributor
Author
|
I also ran into pypa/setuptools#4501 along the way. Specifically on Python3.8/Windows runner... other are fine |
Contributor
Author
|
Ok seems like I can't make it run under Windows/Py3.8. |
Contributor
|
Maybe you want to try this again, now that it's not poetry based? |
LecrisUT
reviewed
Jul 9, 2025
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: 3.8 | ||
| python-version: 3.12 |
Contributor
There was a problem hiding this comment.
Suggested change
| python-version: 3.12 | |
| python-version: 3.x |
If you want to minimize maintenance
Co-authored-by: Cristian Le <github@lecris.me>
mauvilsa
requested changes
Jul 14, 2025
LecrisUT
reviewed
Jul 14, 2025
| ] | ||
| docs = [ | ||
| "pydoctor >= 22.3.0", | ||
| "pydoctor >= 25.4.0", |
Contributor
There was a problem hiding this comment.
My only remaining comment is about this change? Is it needed?
mauvilsa
reviewed
Jul 14, 2025
mauvilsa
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Github workflow to use "latest" versions of the three tested OS. Also run tests under Python 3.13 as well.