Open
Conversation
rr-
requested changes
Aug 3, 2021
Owner
rr-
left a comment
There was a problem hiding this comment.
Please create separate tests for strip_initial_whitespace function. Also I don't quite understand its purpose, which tests will help with.
CI is failing on style checks. https://github.com/rr-/docstring_parser/#contributing
Owner
|
Also in Google style if we have: I'd expect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests pass, but I have no idea if I did it the right way. Hoping this is easy enough for someone more experienced to pick up.