The spec file is missing the value for a string created with #define#128
Open
ellisvelo wants to merge 1 commit intorpav:llvm-17.0.0from
Open
The spec file is missing the value for a string created with #define#128ellisvelo wants to merge 1 commit intorpav:llvm-17.0.0from
ellisvelo wants to merge 1 commit intorpav:llvm-17.0.0from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I ran into a problem where the generated spec file didn't have the value for a #define with a string. For example,
#define SDL_PROP_TEXTURE_CREATE_FORMAT_NUMBER "SDL.texture.create.format"would only have the name, but not the value in the spec file.I noticed that it did work with an older llvm-12.x branch and then found out that isAscii() was renamed to isOrdinary(): llvm/llvm-project@a9a60f2
Making use of isOrdinary() does provide the value for the #define in the spec file. Thanks for creating c2ffi because it really does make it easier to interface with other libraries.