Add support for Google Artifact Registry (GAR)#167
Merged
rpardini merged 2 commits intorpardini:masterfrom Mar 17, 2025
Merged
Conversation
Owner
|
Nice, let's run the test suite and see. If it passes, could you add a test to https://github.com/rpardini/docker-registry-proxy/blob/master/.github/workflows/test.yaml#L20-L24 ? |
by GAR behind the scenes.
Contributor
Author
|
Thank you for the quick response Ricardo! I have added a test case, although it's not as straightforward a test as I would have liked. While it's possible to configure a GAR repository to be publicly accessible, I haven't been able to find any public GAR repos maintained by Google, aside from GCR repos that have been migrated to GAR (which is an ongoing migration this spring). I could publish an image from GAR from my own Google Cloud account, but I don't think it'd be ideal to have tests depend on something that fragile (I am just an internet stranger after all). I chose Manually testing the proxy with this image appears to validate that it's a good image to test, as errors are thrown when I run a version of Before my fix: After my fix: |
rpardini
approved these changes
Mar 17, 2025
Owner
rpardini
left a comment
rpardini
left a comment
There was a problem hiding this comment.
All tests, including the new one, green.
Contributor
Author
|
Nice! Thanks for running the tests and approving. Anything else I need to do to get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #159 and adds support for Google Artifact Registry (GAR).
I have added the proxy buffer tweaks that @vitaliihrynko1 suggested in the original issue, as well as my own tweak of the
$orig_locvariable which resolves the issue of redirection from/v2/to/artifacts-download/in my testing.I'm certainly no nginx expert, so it's very possible that I did something completely wrong. Critique is welcome!