Support numpy operators on GraphArrayView#317
Merged
Conversation
Operations between a GraphArrayView and numpy arrays or scalars did not cast the view to its array content: 'view[t] == 0' silently returned Python's identity False, and 'view[t] + 1' / 'view[t] > 0' raised TypeError. Array operands only worked through numpy's reflected ops. Make BaseReadOnlyArray inherit NDArrayOperatorsMixin and implement __array_ufunc__, materializing read-only array operands before delegating to the ufunc. 'out=' is rejected (read-only) and identity hashing is kept (the mixin's __eq__ would otherwise disable it, breaking signal connections).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Operations between a
GraphArrayViewand numpy arrays/scalars didn't cast the view to its array content:view[t] == 0silently returned Python's identityFalse, andview[t] + 1/view[t] > 0raisedTypeError.BaseReadOnlyArraynow inheritsNDArrayOperatorsMixinand implements__array_ufunc__, materializing read-only operands before delegating to the ufunc.out=is rejected (read-only) and identity hashing is preserved.Added a test covering comparisons and arithmetic with arrays, scalars, and other views, e.g.
array_view[t] == np.zeros(frame_shape).