Don't mutate caller's attrs dict in RustWorkXGraph.update_edge_attrs#313
Merged
Merged
Conversation
…ttrs
update_edge_attrs wrote the scalar-to-list broadcast back into the
caller's dict ({'w': 1.5} became {'w': [1.5, 1.5]}), so reusing the
same dict for a second call with a different edge count raised a
wrong-size error. update_node_attrs already broadcasts into a local
variable; do the same here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scalar values were broadcast in place (
attrs[key] = [value] * size), so the caller's dict was mutated and reusing it with a different edge count raised a bogus wrong-size error.Broadcast into a local copy, as
update_node_attrsalready does.Extended the existing backend test to assert the dict is untouched.