Fix multiprocessing_apply crash on empty sequences with n_workers > 1#312
Merged
Merged
Conversation
With an empty sequence and n_workers > 1, multiprocessing_apply reached Pool(min(n_workers, 0)) and raised 'ValueError: Number of processes must be at least 1'. This is reachable from any operator applied to a graph without time points (e.g. edges operators on an empty graph) when parallelism is enabled. Return early for empty input instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
multiprocessing_applyreachedPool(0)for empty sequences whenn_workers > 1, raisingValueError. Reachable from any operator on a graph without time points when parallelism is enabled.Return early for empty input.
Added tests for empty and non-empty sequences with 1 and 2 workers.