Reset stale node solution values in NearestNeighborsSolver#311
Merged
Conversation
When re-solving a graph whose nodes already carried the solution attribute, NearestNeighborsSolver only reset the edge values and left node values from the previous solve untouched. Nodes dropped from the new solution kept solution=True, so the returned solution subgraph contained stale nodes. Mirror the edge path (and ILPSolver) by resetting node values to False when reset=True and the output key already exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-solving a graph with
reset=Trueonly reset edge solution values; nodes dropped from the new solution keptsolution=True, leaking stale nodes into the solution subgraph.Reset node values to
Falsewhen the output key already exists, mirroring the edge path andILPSolver.Added a regression test re-solving with a tighter
max_children.