node_updated signal sends changed_keys list#310
Merged
JoOkuma merged 2 commits intoJul 1, 2026
Conversation
…cheaper decisions on when to update themselves
Contributor
Author
|
Speedup proof: 
|
JoOkuma
approved these changes
Jul 1, 2026
JoOkuma
left a comment
JoOkuma
left a comment
Member
There was a problem hiding this comment.
@TeunHuijben, awesome PR.
It's cool to see the speedup on the benchmarks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most listeners of the
node_updatedsignal only need to act on changes to certain keys. (GraphArrayView, SpatialFilter, BBoxSpatialFilter)Currently, the
node_updatedsignal returns the pull dataframe containing the old and new attributes. Then it is up to the listeners to check if they really changed.This PR adds a
changed_keyslist to thenode_updatedsignal, to make it easier and faster for listeners to make this decision. The just merged benchmark should (hopefully) show the improvement.